]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
OWE: Do not try to enable PMF for non-RSN associations
authorPurushottam Kushwaha <pkushwah@codeaurora.org>
Tue, 18 Sep 2018 11:04:09 +0000 (16:34 +0530)
committerJouni Malinen <j@w1.fi>
Wed, 3 Oct 2018 21:26:41 +0000 (00:26 +0300)
Explicitly set the PMF configuration to 0 (NO_MGMT_FRAME_PROTECTION) for
non-RSN associations. This specifically helps with OWE transition mode
when the network block is configured with PMF set to required, but the
BSS selected is in open mode. There is no point to try to enable PMF for
such an association.

This fixes issues with drivers that use the NL80211_ATTR_USE_MFP
attribute to set expectations for PMF use. The combination of non-RSN
connection with claimed requirement for PMF (NL80211_MFP_REQUIRED) could
cause such drivers to reject the connection in OWE transition mode.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
wpa_supplicant/wpa_supplicant.c

index 2180238321d8dba42fe5ad0e995cb35ff0ef6fad..4531c62a7727a24d92d0e0c0566731d1d4945279 100644 (file)
@@ -3075,6 +3075,11 @@ static void wpas_start_assoc_cb(struct wpa_radio_work *work, int deinit)
                                "MFP: require MFP");
                        params.mgmt_frame_protection =
                                MGMT_FRAME_PROTECTION_REQUIRED;
+#ifdef CONFIG_OWE
+               } else if (!rsn && (ssid->key_mgmt & WPA_KEY_MGMT_OWE) &&
+                          !ssid->owe_only) {
+                       params.mgmt_frame_protection = NO_MGMT_FRAME_PROTECTION;
+#endif /* CONFIG_OWE */
                }
        }
 #endif /* CONFIG_IEEE80211W */