]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Add missing return statements after self_destruct()
authorAmos Jeffries <squid3@treenet.co.nz>
Thu, 23 Feb 2017 11:14:03 +0000 (00:14 +1300)
committerAmos Jeffries <squid3@treenet.co.nz>
Thu, 23 Feb 2017 11:14:03 +0000 (00:14 +1300)
 Detected by Coverity Scan. Issue 1364716.

src/store/Disk.cc

index dbdcaa5c2ade3537399715be065c4b46a230e472..6a0af3f1dacbe09676952236a5726a36f606792d 100644 (file)
@@ -282,8 +282,10 @@ Store::Disk::parseOptions(int isaReconfig)
         debugs(3,2, "cache_dir " << name << '=' << (value ? value : ""));
 
         if (newOption)
-            if (!newOption->parse(name, value, isaReconfig))
+            if (!newOption->parse(name, value, isaReconfig)) {
                 self_destruct();
+                return;
+            }
     }
 
     delete newOption;
@@ -352,8 +354,10 @@ Store::Disk::optionObjectSizeParse(char const *option, const char *value, int is
     } else
         return false;
 
-    if (!value)
+    if (!value) {
         self_destruct();
+        return false;
+    }
 
     int64_t size = strtoll(value, NULL, 10);