]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
powerpc64/ftrace: Support .text larger than 32MB with out-of-line stubs
authorNaveen N Rao <naveen@kernel.org>
Wed, 30 Oct 2024 07:08:46 +0000 (12:38 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 31 Oct 2024 00:00:55 +0000 (11:00 +1100)
We are restricted to a .text size of ~32MB when using out-of-line
function profile sequence. Allow this to be extended up to the previous
limit of ~64MB by reserving space in the middle of .text.

A new config option CONFIG_PPC_FTRACE_OUT_OF_LINE_NUM_RESERVE is
introduced to specify the number of function stubs that are reserved in
.text. On boot, ftrace utilizes stubs from this area first before using
the stub area at the end of .text.

A ppc64le defconfig has ~44k functions that can be traced. A more
conservative value of 32k functions is chosen as the default value of
PPC_FTRACE_OUT_OF_LINE_NUM_RESERVE so that we do not allot more space
than necessary by default. If building a kernel that only has 32k
trace-able functions, we won't allot any more space at the end of .text
during the pass on vmlinux.o. Otherwise, only the remaining functions
get space for stubs at the end of .text. This default value should help
cover a .text size of ~48MB in total (including space reserved at the
end of .text which can cover up to 32MB), which should be sufficient for
most common builds. For a very small kernel build, this can be set to 0.
Or, this can be bumped up to a larger value to support vmlinux .text
size up to ~64MB.

Signed-off-by: Naveen N Rao <naveen@kernel.org>
Signed-off-by: Hari Bathini <hbathini@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://patch.msgid.link/20241030070850.1361304-14-hbathini@linux.ibm.com
arch/powerpc/Kconfig
arch/powerpc/include/asm/ftrace.h
arch/powerpc/kernel/trace/ftrace.c
arch/powerpc/kernel/trace/ftrace_entry.S
arch/powerpc/tools/Makefile
arch/powerpc/tools/ftrace-gen-ool-stubs.sh

index c995f3fe19e9a6c3654af5819718a83ff9d8ea77..50d418f72ee8e500bf3b54b8bdcf59a6afa955fe 100644 (file)
@@ -573,6 +573,18 @@ config PPC_FTRACE_OUT_OF_LINE
        def_bool PPC64 && ARCH_USING_PATCHABLE_FUNCTION_ENTRY
        select ARCH_WANTS_PRE_LINK_VMLINUX
 
+config PPC_FTRACE_OUT_OF_LINE_NUM_RESERVE
+       int "Number of ftrace out-of-line stubs to reserve within .text"
+       depends on PPC_FTRACE_OUT_OF_LINE
+       default 32768
+       help
+         Number of stubs to reserve for use by ftrace. This space is
+         reserved within .text, and is distinct from any additional space
+         added at the end of .text before the final vmlinux link. Set to
+         zero to have stubs only be generated at the end of vmlinux (only
+         if the size of vmlinux is less than 32MB). Set to a higher value
+         if building vmlinux larger than 48MB.
+
 config HOTPLUG_CPU
        bool "Support for enabling/disabling CPUs"
        depends on SMP && (PPC_PSERIES || \
index bdbafc668b20ad01280b0fb72d81ce7c079fed4f..28f3590ca78089148c33c6ef5845b03619c4d999 100644 (file)
@@ -138,8 +138,10 @@ extern unsigned int ftrace_tramp_text[], ftrace_tramp_init[];
 struct ftrace_ool_stub {
        u32     insn[4];
 };
-extern struct ftrace_ool_stub ftrace_ool_stub_text_end[], ftrace_ool_stub_inittext[];
-extern unsigned int ftrace_ool_stub_text_end_count, ftrace_ool_stub_inittext_count;
+extern struct ftrace_ool_stub ftrace_ool_stub_text_end[], ftrace_ool_stub_text[],
+                             ftrace_ool_stub_inittext[];
+extern unsigned int ftrace_ool_stub_text_end_count, ftrace_ool_stub_text_count,
+                   ftrace_ool_stub_inittext_count;
 #endif
 void ftrace_free_init_tramp(void);
 unsigned long ftrace_call_adjust(unsigned long addr);
index 1fee074388cc64647d40802163442f8d3075585a..bee2c54a8c047d927d8bcd9bceccc3e5ab3d9ad5 100644 (file)
@@ -168,7 +168,7 @@ static int ftrace_get_call_inst(struct dyn_ftrace *rec, unsigned long addr, ppc_
 static int ftrace_init_ool_stub(struct module *mod, struct dyn_ftrace *rec)
 {
 #ifdef CONFIG_PPC_FTRACE_OUT_OF_LINE
-       static int ool_stub_text_end_index, ool_stub_inittext_index;
+       static int ool_stub_text_index, ool_stub_text_end_index, ool_stub_inittext_index;
        int ret = 0, ool_stub_count, *ool_stub_index;
        ppc_inst_t inst;
        /*
@@ -191,9 +191,22 @@ static int ftrace_init_ool_stub(struct module *mod, struct dyn_ftrace *rec)
                ool_stub_index = &ool_stub_inittext_index;
                ool_stub_count = ftrace_ool_stub_inittext_count;
        } else if (is_kernel_text(rec->ip)) {
-               ool_stub = ftrace_ool_stub_text_end;
-               ool_stub_index = &ool_stub_text_end_index;
-               ool_stub_count = ftrace_ool_stub_text_end_count;
+               /*
+                * ftrace records are sorted, so we first use up the stub area within .text
+                * (ftrace_ool_stub_text) before using the area at the end of .text
+                * (ftrace_ool_stub_text_end), unless the stub is out of range of the record.
+                */
+               if (ool_stub_text_index >= ftrace_ool_stub_text_count ||
+                   !is_offset_in_branch_range((long)rec->ip -
+                                              (long)&ftrace_ool_stub_text[ool_stub_text_index])) {
+                       ool_stub = ftrace_ool_stub_text_end;
+                       ool_stub_index = &ool_stub_text_end_index;
+                       ool_stub_count = ftrace_ool_stub_text_end_count;
+               } else {
+                       ool_stub = ftrace_ool_stub_text;
+                       ool_stub_index = &ool_stub_text_index;
+                       ool_stub_count = ftrace_ool_stub_text_count;
+               }
 #ifdef CONFIG_MODULES
        } else if (mod) {
                ool_stub = mod->arch.ool_stubs;
index 5b2fc6483dce9051e9c2f26e00cb39e1d737cccb..a6bf7f841040375750f5f2af61873407d401941a 100644 (file)
@@ -374,6 +374,14 @@ _GLOBAL(return_to_handler)
        blr
 #endif /* CONFIG_FUNCTION_GRAPH_TRACER */
 
+#ifdef CONFIG_PPC_FTRACE_OUT_OF_LINE
+SYM_DATA(ftrace_ool_stub_text_count, .long CONFIG_PPC_FTRACE_OUT_OF_LINE_NUM_RESERVE)
+
+SYM_CODE_START(ftrace_ool_stub_text)
+       .space CONFIG_PPC_FTRACE_OUT_OF_LINE_NUM_RESERVE * FTRACE_OOL_STUB_SIZE
+SYM_CODE_END(ftrace_ool_stub_text)
+#endif
+
 .pushsection ".tramp.ftrace.text","aw",@progbits;
 .globl ftrace_tramp_text
 ftrace_tramp_text:
index d2e7ecd5f46f973d02d80032e0edadaf3d4555e9..e1f7afcd9fdfd9c70e9982f4922b20174beca12f 100644 (file)
@@ -1,7 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 
 quiet_cmd_gen_ftrace_ool_stubs = GEN     $@
-      cmd_gen_ftrace_ool_stubs = $< "$(CONFIG_64BIT)" "$(OBJDUMP)" vmlinux.o $@
+       cmd_gen_ftrace_ool_stubs = $< "$(CONFIG_PPC_FTRACE_OUT_OF_LINE_NUM_RESERVE)" "$(CONFIG_64BIT)" \
+                                  "$(OBJDUMP)" vmlinux.o $@
 
 $(obj)/vmlinux.arch.S: $(src)/ftrace-gen-ool-stubs.sh vmlinux.o FORCE
        $(call if_changed,gen_ftrace_ool_stubs)
index 96e1ca5803e4b4ff0323f6bd0fd065ab136c3424..6a201df83524e180362cbb1e42c067740c4c89b1 100755 (executable)
@@ -4,10 +4,11 @@
 # Error out on error
 set -e
 
-is_64bit="$1"
-objdump="$2"
-vmlinux_o="$3"
-arch_vmlinux_S="$4"
+num_ool_stubs_text_builtin="$1"
+is_64bit="$2"
+objdump="$3"
+vmlinux_o="$4"
+arch_vmlinux_S="$5"
 
 RELOCATION=R_PPC64_ADDR64
 if [ -z "$is_64bit" ]; then
@@ -19,15 +20,23 @@ num_ool_stubs_text=$($objdump -r -j __patchable_function_entries "$vmlinux_o" |
 num_ool_stubs_inittext=$($objdump -r -j __patchable_function_entries "$vmlinux_o" |
                         grep ".init.text" | grep -c "$RELOCATION")
 
+if [ "$num_ool_stubs_text" -gt "$num_ool_stubs_text_builtin" ]; then
+       num_ool_stubs_text_end=$((num_ool_stubs_text - num_ool_stubs_text_builtin))
+else
+       num_ool_stubs_text_end=0
+fi
+
 cat > "$arch_vmlinux_S" <<EOF
 #include <asm/asm-offsets.h>
 #include <linux/linkage.h>
 
 .pushsection .tramp.ftrace.text,"aw"
-SYM_DATA(ftrace_ool_stub_text_end_count, .long $num_ool_stubs_text)
+SYM_DATA(ftrace_ool_stub_text_end_count, .long $num_ool_stubs_text_end)
 
 SYM_CODE_START(ftrace_ool_stub_text_end)
-       .space $num_ool_stubs_text * FTRACE_OOL_STUB_SIZE
+#if $num_ool_stubs_text_end
+       .space $num_ool_stubs_text_end * FTRACE_OOL_STUB_SIZE
+#endif
 SYM_CODE_END(ftrace_ool_stub_text_end)
 .popsection