]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
devpts: Fix type for uid and gid params
authorDavid Howells <dhowells@redhat.com>
Wed, 2 Apr 2025 12:17:54 +0000 (13:17 +0100)
committerChristian Brauner <brauner@kernel.org>
Mon, 7 Apr 2025 13:22:12 +0000 (15:22 +0200)
Fix devpts to parse uid and gid params using the correct type so that they
get interpreted in the context of the user namespace.

Fixes: cc0876f817d6 ("vfs: Convert devpts to use the new mount API")
Reported-by: Debarshi Ray <dray@redhat.com>
Closes: https://github.com/containers/podman/issues/25751
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/759134.1743596274@warthog.procyon.org.uk
cc: Eric Sandeen <sandeen@redhat.com>
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/devpts/inode.c

index 42e4d6eeb29f5ba86fe3fe4bf1086d13090bcd13..9c20d78e41f6b438c9d63a429ab47250294804c4 100644 (file)
@@ -89,12 +89,12 @@ enum {
 };
 
 static const struct fs_parameter_spec devpts_param_specs[] = {
-       fsparam_u32     ("gid",         Opt_gid),
+       fsparam_gid     ("gid",         Opt_gid),
        fsparam_s32     ("max",         Opt_max),
        fsparam_u32oct  ("mode",        Opt_mode),
        fsparam_flag    ("newinstance", Opt_newinstance),
        fsparam_u32oct  ("ptmxmode",    Opt_ptmxmode),
-       fsparam_u32     ("uid",         Opt_uid),
+       fsparam_uid     ("uid",         Opt_uid),
        {}
 };