]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
rtla: Fix consistency in getopt_long for timerlat_hist
authorGabriele Monaco <gmonaco@redhat.com>
Thu, 26 Sep 2024 14:34:17 +0000 (16:34 +0200)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Fri, 4 Oct 2024 23:33:38 +0000 (19:33 -0400)
Commit e9a4062e1527 ("rtla: Add --trace-buffer-size option") adds a new
long option to rtla utilities, but among all affected files,
timerlat_hist misses a trailing `:` in the corresponding short option
inside the getopt string (e.g. `\3:`). This patch propagates the `:`.

Although this change is not functionally required, it improves
consistency and slightly reduces the likelihood a future change would
introduce a problem.

Cc: John Kacur <jkacur@redhat.com>
Cc: Luis Goncalves <lgoncalv@redhat.com>
Cc: Tomas Glozar <tglozar@redhat.com>
Link: https://lore.kernel.org/20240926143417.54039-1-gmonaco@redhat.com
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
tools/tracing/rtla/src/timerlat_hist.c

index a3907c390d67a5d710682dda8209691669ca5e88..1f9137c592f459adc68d7fa27e46e7cdbed3d427 100644 (file)
@@ -778,7 +778,7 @@ static struct timerlat_hist_params
                /* getopt_long stores the option index here. */
                int option_index = 0;
 
-               c = getopt_long(argc, argv, "a:c:C::b:d:e:E:DhH:i:knp:P:s:t::T:uU0123456:7:8:9\1\2:\3",
+               c = getopt_long(argc, argv, "a:c:C::b:d:e:E:DhH:i:knp:P:s:t::T:uU0123456:7:8:9\1\2:\3:",
                                 long_options, &option_index);
 
                /* detect the end of the options. */