pgbench: Remove dead code

doConnect() never returns connections in state CONNECTION_BAD, so
checking for that is pointless.  Remove the code that does.

This code has been dead since ba708ea3dc84, 20 years ago.

Discussion: https://postgr.es/m/20210126195224.GA20361@alvherre.pgsql
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>

diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
index 875b764fa9e75fd4d2b33d7e4314e5b29c5cb96c..566593cde669835b345419d6653f6ba6e28621bf 100644 (file)
--- a/src/bin/pgbench/pgbench.c
+++ b/src/bin/pgbench/pgbench.c
@@ -3310,14 +3310,6 @@ main(int argc, char **argv)
        if (con == NULL)
                exit(1);
 
-       if (PQstatus(con) == CONNECTION_BAD)
-       {
-               fprintf(stderr, "connection to database \"%s\" failed\n",
-                               PQdb(con) ? PQdb(con) : "");
-               fprintf(stderr, "%s", PQerrorMessage(con));
-               exit(1);
-       }
-
        if (ttype != 3)
        {
                /*