]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
tdb: Fix some signed/unsigned comparisons
authorMartin Schwenke <martin@meltin.net>
Thu, 7 May 2020 06:57:07 +0000 (16:57 +1000)
committerVolker Lendecke <vl@samba.org>
Thu, 16 Jul 2020 01:29:45 +0000 (01:29 +0000)
[207/389] Compiling lib/tdb/tools/tdbdump.c
../../../lib/tdb/tools/tdbrestore.c: In function ‘read_linehead’:
../../../lib/tdb/tools/tdbrestore.c:43:13: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
   43 |  for (i=0; i<sizeof(prefix); i++) {
      |             ^
../../../lib/tdb/tools/tdbrestore.c: In function ‘read_data’:
../../../lib/tdb/tools/tdbrestore.c:95:13: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
   95 |  for (i=0; i<size; i++) {
      |             ^

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
lib/tdb/tools/tdbrestore.c

index 81c986c60038b3490c6113175ffad394153cce51..9d5146272cc0c2538f128130d7bf6aa9b2224154 100644 (file)
@@ -27,7 +27,8 @@
 
 static int read_linehead(FILE *f)
 {
-       int i, c;
+       size_t i;
+       int c;
        int num_bytes;
        char prefix[128];
 
@@ -84,7 +85,7 @@ static int read_hex(void) {
 
 static int read_data(FILE *f, TDB_DATA *d, size_t size) {
        int c, low, high;
-       int i;
+       size_t i;
 
        d->dptr = (unsigned char *)malloc(size);
        if (d->dptr == NULL) {