]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
tty: hvc_console: Call hvc_kick in hvc_write unconditionally
authorFabian Vogt <fvogt@suse.de>
Fri, 15 Aug 2025 11:33:28 +0000 (13:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Aug 2025 10:50:30 +0000 (12:50 +0200)
After hvc_write completes, call hvc_kick also in the case the output
buffer has been drained, to ensure tty_wakeup gets called.

This fixes that functions which wait for a drained buffer got stuck
occasionally.

Cc: stable <stable@kernel.org>
Closes: https://bugzilla.opensuse.org/show_bug.cgi?id=1230062
Signed-off-by: Fabian Vogt <fvogt@suse.de>
Link: https://lore.kernel.org/r/2011735.PYKUYFuaPT@fvogt-thinkpad
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/hvc/hvc_console.c

index cd1f657f782df218b12e315dd3fdab79474d2bec..13c663a154c4e88fc242a0d129d164c89b642c82 100644 (file)
@@ -543,10 +543,10 @@ static ssize_t hvc_write(struct tty_struct *tty, const u8 *buf, size_t count)
        }
 
        /*
-        * Racy, but harmless, kick thread if there is still pending data.
+        * Kick thread to flush if there's still pending data
+        * or to wakeup the write queue.
         */
-       if (hp->n_outbuf)
-               hvc_kick();
+       hvc_kick();
 
        return written;
 }