thermal: core: Change passive_delay and polling_delay data type

It is better to use unsigned int as the data type for the passive_delay
and polling_delay arguments of thermal_zone_device_register_with_trips()
because they are implicitly cast to unsigned int anyway in
thermal_set_delay_jiffies() and if they happen to be negative at that
point, the resulting behavior may not be as desired.

Update the thermal_zone_device_register_with_trips() definition
accordingly.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://patch.msgid.link/5803791.DvuYhMxLoT@rjwysocki.net
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 3eb85301d32522b24a5f9f94244ae90729e99c0e..7139f729a83d4cf680cfba5e2f5ab661c0e9fcc1 100644 (file)
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1356,7 +1356,8 @@ thermal_zone_device_register_with_trips(const char *type,
                                        int num_trips, void *devdata,
                                        const struct thermal_zone_device_ops *ops,
                                        const struct thermal_zone_params *tzp,
-                                       int passive_delay, int polling_delay)
+                                       unsigned int passive_delay,
+                                       unsigned int polling_delay)
 {
        const struct thermal_trip *trip = trips;
        struct thermal_zone_device *tz;

diff --git a/include/linux/thermal.h b/include/linux/thermal.h
index f732dab203683702db82651cc8e0a4bd35b14672..cd0045915af50fd22f912754652454aba0e9fa11 100644 (file)
--- a/include/linux/thermal.h
+++ b/include/linux/thermal.h
@@ -221,7 +221,8 @@ struct thermal_zone_device *thermal_zone_device_register_with_trips(
                                        int num_trips, void *devdata,
                                        const struct thermal_zone_device_ops *ops,
                                        const struct thermal_zone_params *tzp,
-                                       int passive_delay, int polling_delay);
+                                       unsigned int passive_delay,
+                                       unsigned int polling_delay);
 
 struct thermal_zone_device *thermal_tripless_zone_device_register(
                                        const char *type,