]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4-rpc_server/drsuapi: Improve debugging of invalid DNs
authorAndrew Bartlett <abartlet@samba.org>
Tue, 27 Jun 2023 00:18:24 +0000 (12:18 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Sun, 13 Aug 2023 21:59:29 +0000 (21:59 +0000)
This is still unreachable, so but improve the logging
to give more detail in this area anyway.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15401

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
source4/rpc_server/drsuapi/getncchanges.c

index 256e5f178e31d549648bae49b294709101c96e59..4f2e60b55caad6b36c6940960e5b6dc3cf805030 100644 (file)
@@ -2977,8 +2977,9 @@ allowed:
                         * This can't fail as we have done this above
                         * implicitly but not got the DN out
                         */
-                       DBG_ERR("Bad DN '%s'\n",
-                               drs_ObjectIdentifier_to_debug_string(mem_ctx, ncRoot));
+                       DBG_ERR("Bad DN '%s' as Naming Context for GetNCChanges: %s\n",
+                               drs_ObjectIdentifier_to_debug_string(mem_ctx, ncRoot),
+                               ldb_strerror(ret));
                        return WERR_DS_DRA_INVALID_PARAMETER;
                }
                if (ldb_dn_compare(new_dn, getnc_state->ncRoot_dn) != 0) {