]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: goto error when value of max_sectors is too large
authorLuyao Huang <lhuang@redhat.com>
Fri, 12 Dec 2014 02:32:54 +0000 (10:32 +0800)
committerJán Tomko <jtomko@redhat.com>
Thu, 22 Jan 2015 11:37:52 +0000 (12:37 +0100)
Output error when we try to set a too large max_sectors.
Just like queues and cmd_per_lun here.

Signed-off-by: Luyao Huang <lhuang@redhat.com>
(cherry picked from commit ce1d2f63152290098450fa2beecdee79cf929456)
Signed-off-by: Ján Tomko <jtomko@redhat.com>
src/conf/domain_conf.c

index 2ea57ac85cd05cf31b3326c5616eed45f5f0c2bb..6b64f51002a9741ec8e8f7e356d0e3c99470148f 100644 (file)
@@ -6435,6 +6435,7 @@ virDomainControllerDefParseXML(xmlNodePtr node,
     if (max_sectors && virStrToLong_ui(max_sectors, NULL, 10, &def->max_sectors) < 0) {
         virReportError(VIR_ERR_XML_ERROR,
                        _("Malformed 'max_sectors' value %s'"), max_sectors);
+        goto error;
     }
 
     if (virDomainDeviceInfoParseXML(node, NULL, &def->info, flags) < 0)