]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: ath11k: Use of_property_present() to test property presence
authorRob Herring (Arm) <robh@kernel.org>
Tue, 8 Apr 2025 19:02:11 +0000 (14:02 -0500)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Sat, 12 Apr 2025 04:19:29 +0000 (21:19 -0700)
The use of of_property_read_u32() isn't really correct as
"memory-region" contains phandles (though those happen to be u32s. As
it is just testing for property presence, use of_property_present()
instead.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20250408190211.2505737-2-robh@kernel.org
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath11k/pci.c

index 630df6b1d82dff357c8259475cc9b03e4580a1b9..78444f8ea15356f1f4c90a496efd52780499bfb2 100644 (file)
@@ -929,7 +929,7 @@ static int ath11k_pci_probe(struct pci_dev *pdev,
 {
        struct ath11k_base *ab;
        struct ath11k_pci *ab_pci;
-       u32 soc_hw_version_major, soc_hw_version_minor, addr;
+       u32 soc_hw_version_major, soc_hw_version_minor;
        int ret;
        u32 sub_version;
 
@@ -955,8 +955,7 @@ static int ath11k_pci_probe(struct pci_dev *pdev,
         * from DT. If memory is reserved from DT for FW, ath11k driver need not
         * allocate memory.
         */
-       ret = of_property_read_u32(ab->dev->of_node, "memory-region", &addr);
-       if (!ret)
+       if (of_property_present(ab->dev->of_node, "memory-region"))
                set_bit(ATH11K_FLAG_FIXED_MEM_RGN, &ab->dev_flags);
 
        ret = ath11k_pci_claim(ab_pci, pdev);