]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: mt9p031: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:12 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:23 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/mt9p031.c

index 4ef5fb06131d5dc29710a323424c1b817b7a4a27..4df8f2be15f3d7a7540529d42fcfd4c0faaf1e74 100644 (file)
@@ -233,9 +233,10 @@ static int mt9p031_clk_setup(struct mt9p031 *mt9p031)
        unsigned long ext_freq;
        int ret;
 
-       mt9p031->clk = devm_clk_get(&client->dev, NULL);
+       mt9p031->clk = devm_v4l2_sensor_clk_get(&client->dev, NULL);
        if (IS_ERR(mt9p031->clk))
-               return PTR_ERR(mt9p031->clk);
+               return dev_err_probe(&client->dev, PTR_ERR(mt9p031->clk),
+                                    "failed to get the clock\n");
 
        ret = clk_set_rate(mt9p031->clk, mt9p031->ext_freq);
        if (ret < 0)