]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/damon/tests/core-kunit: handle alloc failures on damos_test_filter_out()
authorSeongJae Park <sj@kernel.org>
Sat, 1 Nov 2025 18:20:09 +0000 (11:20 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 17 Nov 2025 01:28:33 +0000 (17:28 -0800)
damon_test_filter_out() is assuming all dynamic memory allocation in it
will succeed.  Those are indeed likely in the real use cases since those
allocations are too small to fail, but theoretically those could fail.  In
the case, inappropriate memory access can happen.  Fix it by appropriately
cleanup pre-allocated memory and skip the execution of the remaining tests
in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-16-sj@kernel.org
Fixes: 26713c890875 ("mm/damon/core-test: add a unit test for __damos_filter_out()")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [6.6+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/tests/core-kunit.h

index 5af8275ffd7dd89b6eff058f25f844281fc7d0e6..a03ae9ddd88a8ca52068ef4a4d41003a20d6af72 100644 (file)
@@ -542,11 +542,22 @@ static void damos_test_filter_out(struct kunit *test)
        struct damos_filter *f;
 
        f = damos_new_filter(DAMOS_FILTER_TYPE_ADDR, true, false);
+       if (!f)
+               kunit_skip(test, "filter alloc fail");
        f->addr_range = (struct damon_addr_range){
                .start = DAMON_MIN_REGION * 2, .end = DAMON_MIN_REGION * 6};
 
        t = damon_new_target();
+       if (!t) {
+               damos_destroy_filter(f);
+               kunit_skip(test, "target alloc fail");
+       }
        r = damon_new_region(DAMON_MIN_REGION * 3, DAMON_MIN_REGION * 5);
+       if (!r) {
+               damos_destroy_filter(f);
+               damon_free_target(t);
+               kunit_skip(test, "region alloc fail");
+       }
        damon_add_region(r, t);
 
        /* region in the range */