]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: ag71xx: move assignment into main loop
authorRosen Penev <rosenp@gmail.com>
Mon, 30 Sep 2024 18:18:23 +0000 (11:18 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 4 Oct 2024 15:56:27 +0000 (08:56 -0700)
Effectively what's going on here is there's a main loop and an identical
one below with a single assignment. Simpler to move it up.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://patch.msgid.link/20240930181823.288892-6-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/atheros/ag71xx.c

index 067a012a57995f63424012441d8ae828d33695a3..3d4c3d8698e2c60c0196a2131c31266792b83422 100644 (file)
@@ -1646,6 +1646,7 @@ static int ag71xx_rx_packets(struct ag71xx *ag, int limit)
 
                skb->dev = ndev;
                skb->ip_summed = CHECKSUM_NONE;
+               skb->protocol = eth_type_trans(skb, ndev);
                list_add_tail(&skb->list, &rx_list);
 
 next:
@@ -1657,8 +1658,6 @@ next:
 
        ag71xx_ring_rx_refill(ag);
 
-       list_for_each_entry(skb, &rx_list, list)
-               skb->protocol = eth_type_trans(skb, ndev);
        netif_receive_skb_list(&rx_list);
 
        netif_dbg(ag, rx_status, ndev, "rx finish, curr=%u, dirty=%u, done=%d\n",