]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
sched/deadline: Use hrtick_enabled_dl() before start_hrtick_dl()
authorPhil Auld <pauld@redhat.com>
Fri, 4 Oct 2024 12:37:29 +0000 (08:37 -0400)
committerPeter Zijlstra <peterz@infradead.org>
Fri, 11 Oct 2024 08:49:32 +0000 (10:49 +0200)
The deadline server code moved one of the start_hrtick_dl() calls
but dropped the dl specific hrtick_enabled check. This causes hrticks
to get armed even when sched_feat(HRTICK_DL) is false. Fix it.

Fixes: 63ba8422f876 ("sched/deadline: Introduce deadline servers")
Signed-off-by: Phil Auld <pauld@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Juri Lelli <juri.lelli@redhat.com>
Link: https://lore.kernel.org/r/20241004123729.460668-1-pauld@redhat.com
kernel/sched/deadline.c

index 9ce93d0bf4523a0a747721284cbf503a3c9d4a5d..be1b917dc8ce4c457109123d65cfe14c99642138 100644 (file)
@@ -2385,7 +2385,7 @@ static void set_next_task_dl(struct rq *rq, struct task_struct *p, bool first)
 
        deadline_queue_push_tasks(rq);
 
-       if (hrtick_enabled(rq))
+       if (hrtick_enabled_dl(rq))
                start_hrtick_dl(rq, &p->dl);
 }