]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: gw-pld: use new line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 7 Apr 2025 07:13:17 +0000 (09:13 +0200)
committerBartosz Golaszewski <brgl@bgdev.pl>
Thu, 17 Apr 2025 11:58:54 +0000 (13:58 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/r/20250407-gpiochip-set-rv-gpio-part1-v1-8-78399683ca38@linaro.org
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpio-gw-pld.c

index 7e29a2d8de1aafed434e97b1a78f3636918035aa..a40ba99a3aea05cf4edb9a0c3efa4a1c2e6755fa 100644 (file)
@@ -62,9 +62,9 @@ static int gw_pld_output8(struct gpio_chip *gc, unsigned offset, int value)
        return i2c_smbus_write_byte(gw->client, gw->out);
 }
 
-static void gw_pld_set8(struct gpio_chip *gc, unsigned offset, int value)
+static int gw_pld_set8(struct gpio_chip *gc, unsigned int offset, int value)
 {
-       gw_pld_output8(gc, offset, value);
+       return gw_pld_output8(gc, offset, value);
 }
 
 static int gw_pld_probe(struct i2c_client *client)
@@ -86,7 +86,7 @@ static int gw_pld_probe(struct i2c_client *client)
        gw->chip.direction_input = gw_pld_input8;
        gw->chip.get = gw_pld_get8;
        gw->chip.direction_output = gw_pld_output8;
-       gw->chip.set = gw_pld_set8;
+       gw->chip.set_rv = gw_pld_set8;
        gw->client = client;
 
        /*