]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/simpledrm: Do not upcast in release helpers
authorThomas Zimmermann <tzimmermann@suse.de>
Mon, 7 Apr 2025 13:47:24 +0000 (15:47 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 8 Apr 2025 07:11:40 +0000 (09:11 +0200)
The res pointer passed to simpledrm_device_release_clocks() and
simpledrm_device_release_regulators() points to an instance of
struct simpledrm_device. No need to upcast from struct drm_device.
The upcast is harmless, as DRM device is the first field in struct
simpledrm_device.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 11e8f5fd223b ("drm: Add simpledrm driver")
Cc: <stable@vger.kernel.org> # v5.14+
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Link: https://lore.kernel.org/r/20250407134753.985925-2-tzimmermann@suse.de
drivers/gpu/drm/sysfb/simpledrm.c

index cfb1fe07704d7c96cec2e279a38d5e361534e9bb..78672422bcada02fb60f2a778afe93b02394509d 100644 (file)
@@ -275,7 +275,7 @@ static struct simpledrm_device *simpledrm_device_of_dev(struct drm_device *dev)
 
 static void simpledrm_device_release_clocks(void *res)
 {
-       struct simpledrm_device *sdev = simpledrm_device_of_dev(res);
+       struct simpledrm_device *sdev = res;
        unsigned int i;
 
        for (i = 0; i < sdev->clk_count; ++i) {
@@ -373,7 +373,7 @@ static int simpledrm_device_init_clocks(struct simpledrm_device *sdev)
 
 static void simpledrm_device_release_regulators(void *res)
 {
-       struct simpledrm_device *sdev = simpledrm_device_of_dev(res);
+       struct simpledrm_device *sdev = res;
        unsigned int i;
 
        for (i = 0; i < sdev->regulator_count; ++i) {