]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
platform/x86: thinkpad_acpi: Fix 'warning: no previous prototype for' warnings
authorHans de Goede <hdegoede@redhat.com>
Thu, 4 Feb 2021 14:01:57 +0000 (15:01 +0100)
committerHans de Goede <hdegoede@redhat.com>
Thu, 4 Feb 2021 14:15:19 +0000 (15:15 +0100)
Some of the new dytc handling functions are not marked static, even though
they are only used internally.

Mark these static, fixing the following compiler warnings:

drivers/platform/x86/thinkpad_acpi.c:10081:5: warning: no previous prototype for 'dytc_profile_get' [-Wmissing-prototypes]
drivers/platform/x86/thinkpad_acpi.c:10095:5: warning: no previous prototype for 'dytc_cql_command' [-Wmissing-prototypes]
drivers/platform/x86/thinkpad_acpi.c:10133:5: warning: no previous prototype for 'dytc_profile_set' [-Wmissing-prototypes]

Cc: Mark Pearson <markpearson@lenovo.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210204140158.268289-1-hdegoede@redhat.com
drivers/platform/x86/thinkpad_acpi.c

index 18b390153e7f74a9ac24edbb112dc4179cbb6800..42e0a497d69e44b7dd5acd377267e64fbf8a4f5b 100644 (file)
@@ -10078,8 +10078,8 @@ static int convert_profile_to_dytc(enum platform_profile_option profile, int *pe
  * dytc_profile_get: Function to register with platform_profile
  * handler. Returns current platform profile.
  */
-int dytc_profile_get(struct platform_profile_handler *pprof,
-                       enum platform_profile_option *profile)
+static int dytc_profile_get(struct platform_profile_handler *pprof,
+                           enum platform_profile_option *profile)
 {
        *profile = dytc_current_profile;
        return 0;
@@ -10092,7 +10092,7 @@ int dytc_profile_get(struct platform_profile_handler *pprof,
  *  - enable CQL
  *  If not in CQL mode, just run the command
  */
-int dytc_cql_command(int command, int *output)
+static int dytc_cql_command(int command, int *output)
 {
        int err, cmd_err, dummy;
        int cur_funcmode;
@@ -10130,8 +10130,8 @@ int dytc_cql_command(int command, int *output)
  * dytc_profile_set: Function to register with platform_profile
  * handler. Sets current platform profile.
  */
-int dytc_profile_set(struct platform_profile_handler *pprof,
-                       enum platform_profile_option profile)
+static int dytc_profile_set(struct platform_profile_handler *pprof,
+                           enum platform_profile_option profile)
 {
        int output;
        int err;