]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
perf: Use scoped_guard() for mmap_mutex in perf_mmap()
authorPeter Zijlstra <peterz@infradead.org>
Tue, 12 Aug 2025 10:39:11 +0000 (12:39 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Fri, 15 Aug 2025 11:13:01 +0000 (13:13 +0200)
Mostly just re-indent noise.

Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Link: https://lore.kernel.org/r/20250812104019.838047976@infradead.org
kernel/events/core.c

index 3a5fd2b802e4f7e8cdb713bdc4dfb7ef5f4a99d6..41941dfadfcbc756233e5c28f5f620f15e3615b1 100644 (file)
@@ -7146,30 +7146,23 @@ static int perf_mmap(struct file *file, struct vm_area_struct *vma)
        if (vma_size != PAGE_SIZE * nr_pages)
                return -EINVAL;
 
-       mutex_lock(&event->mmap_mutex);
-       ret = -EINVAL;
+       scoped_guard (mutex, &event->mmap_mutex) {
+               /*
+                * This relies on __pmu_detach_event() taking mmap_mutex after marking
+                * the event REVOKED. Either we observe the state, or __pmu_detach_event()
+                * will detach the rb created here.
+                */
+               if (event->state <= PERF_EVENT_STATE_REVOKED)
+                       return -ENODEV;
 
-       /*
-        * This relies on __pmu_detach_event() taking mmap_mutex after marking
-        * the event REVOKED. Either we observe the state, or __pmu_detach_event()
-        * will detach the rb created here.
-        */
-       if (event->state <= PERF_EVENT_STATE_REVOKED) {
-               ret = -ENODEV;
-               goto unlock;
+               if (vma->vm_pgoff == 0)
+                       ret = perf_mmap_rb(vma, event, nr_pages);
+               else
+                       ret = perf_mmap_aux(vma, event, nr_pages);
+               if (ret)
+                       return ret;
        }
 
-       if (vma->vm_pgoff == 0)
-               ret = perf_mmap_rb(vma, event, nr_pages);
-       else
-               ret = perf_mmap_aux(vma, event, nr_pages);
-
-unlock:
-       mutex_unlock(&event->mmap_mutex);
-
-       if (ret)
-               return ret;
-
        /*
         * Since pinned accounting is per vm we cannot allow fork() to copy our
         * vma.