fs: ubifs: Ensure buf is freed before return

Returning directly after buf has been allocated will result in a memory
leak. Instead set the error code and goto the common unwind code to
ensure that buf will be freed before returning.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>

diff --git a/fs/ubifs/lprops.c b/fs/ubifs/lprops.c
index a9e22abe6b401ecc4afb15c632dadbe23199c39f..74beb853b6e1da5076cbc8aad77ae26a76fa3580 100644 (file)
--- a/fs/ubifs/lprops.c
+++ b/fs/ubifs/lprops.c
@@ -1096,14 +1096,16 @@ static int scan_check_cb(struct ubifs_info *c,
                lst->empty_lebs += 1;
                lst->total_free += c->leb_size;
                lst->total_dark += ubifs_calc_dark(c, c->leb_size);
-               return LPT_SCAN_CONTINUE;
+               ret = LPT_SCAN_CONTINUE;
+               goto out;
        }
        if (lp->free + lp->dirty == c->leb_size &&
            !(lp->flags & LPROPS_INDEX)) {
                lst->total_free  += lp->free;
                lst->total_dirty += lp->dirty;
                lst->total_dark  +=  ubifs_calc_dark(c, c->leb_size);
-               return LPT_SCAN_CONTINUE;
+               ret = LPT_SCAN_CONTINUE;
+               goto out;
        }
 
        sleb = ubifs_scan(c, lnum, 0, buf, 0);