]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Don't restrict the ECDSA settable ctx params unnecessarily
authorMatt Caswell <matt@openssl.org>
Wed, 31 Jul 2024 13:24:12 +0000 (14:24 +0100)
committerTomas Mraz <tomas@openssl.org>
Mon, 9 Sep 2024 07:51:50 +0000 (09:51 +0200)
We just allow all possible settables all the time. Some things like the
digest name can't actually be changed in some circumstances - but we already
have checks for those things. It's still possible to pass a digest of the
same name to one that's already been set for example.

Fixes #25012

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25057)

providers/implementations/signature/ecdsa_sig.c

index 440b176783763f0d02fc3563076c1332c42fc328..52607245a4c74bcaa84497d5ae8e9bc2f952fd4c 100644 (file)
@@ -801,18 +801,9 @@ static const OSSL_PARAM settable_ctx_params[] = {
     ECDSA_COMMON_SETTABLE_CTX_PARAMS
 };
 
-static const OSSL_PARAM settable_ctx_params_no_digest[] = {
-    OSSL_PARAM_uint(OSSL_SIGNATURE_PARAM_KAT, NULL),
-    OSSL_PARAM_END
-};
-
 static const OSSL_PARAM *ecdsa_settable_ctx_params(void *vctx,
                                                    ossl_unused void *provctx)
 {
-    PROV_ECDSA_CTX *ctx = (PROV_ECDSA_CTX *)vctx;
-
-    if (ctx != NULL && !ctx->flag_allow_md)
-        return settable_ctx_params_no_digest;
     return settable_ctx_params;
 }