]> git.ipfire.org Git - people/ms/linux.git/commitdiff
em28xx: ensure "closing" messages terminate with a newline
authorRussell King <rmk+kernel@arm.linux.org.uk>
Sat, 20 Dec 2014 12:45:20 +0000 (09:45 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Mar 2015 22:52:51 +0000 (14:52 -0800)
commit 0418ca6073478f54f1da2e4013fa50d36838de75 upstream.

The lockdep splat addressed in a previous commit revealed that at
least one message in em28xx-input.c was missing a new line:

em28178 #0: Closing input extensionINFO: trying to register non-static key.

Further inspection shows several other messages also miss a new line.
These will be fixed in a subsequent patch.

Fixes: aa929ad783c0 ("[media] em28xx: print a message at disconnect")
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Reviewed-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/usb/em28xx/em28xx-audio.c
drivers/media/usb/em28xx/em28xx-dvb.c
drivers/media/usb/em28xx/em28xx-input.c
drivers/media/usb/em28xx/em28xx-video.c

index 957c7ae30efe5f5d724908f9b231e8a0b780e406..fd6816d60ab21fd0d500df6e89d7fc246ba116dc 100644 (file)
@@ -982,7 +982,7 @@ static int em28xx_audio_fini(struct em28xx *dev)
                return 0;
        }
 
-       em28xx_info("Closing audio extension");
+       em28xx_info("Closing audio extension\n");
 
        if (dev->adev.sndcard) {
                snd_card_disconnect(dev->adev.sndcard);
index 9682c52d67d17b3be3d52e9fc9f878f73d2aed9d..bddf38bd7647badec931c0d7c875bb90f9771374 100644 (file)
@@ -1667,7 +1667,7 @@ static int em28xx_dvb_fini(struct em28xx *dev)
        if (!dev->dvb)
                return 0;
 
-       em28xx_info("Closing DVB extension");
+       em28xx_info("Closing DVB extension\n");
 
        dvb = dev->dvb;
        client = dvb->i2c_client_tuner;
index 23f8f6afa2e061a783ee9fa5c0d244c9c6018dcf..99e13dae549cde6d79e07dce1358496ecf23df2a 100644 (file)
@@ -833,7 +833,7 @@ static int em28xx_ir_fini(struct em28xx *dev)
                return 0;
        }
 
-       em28xx_info("Closing input extension");
+       em28xx_info("Closing input extension\n");
 
        em28xx_shutdown_buttons(dev);
 
index 03d5ece0319c63e748f669635889769fc64ea210..da69d065f7fcd556647b047b846b46cc2329eef2 100644 (file)
@@ -1956,7 +1956,7 @@ static int em28xx_v4l2_fini(struct em28xx *dev)
        if (v4l2 == NULL)
                return 0;
 
-       em28xx_info("Closing video extension");
+       em28xx_info("Closing video extension\n");
 
        mutex_lock(&dev->lock);