]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/sti: hda: add bridge before attaching
authorLuca Ceresoli <luca.ceresoli@bootlin.com>
Tue, 28 Oct 2025 10:15:42 +0000 (11:15 +0100)
committerLuca Ceresoli <luca.ceresoli@bootlin.com>
Mon, 3 Nov 2025 12:04:55 +0000 (13:04 +0100)
DRM bridges should be always added to the global bridge list before being
attached.

Acked-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
Acked-by: Alain Volmat <alain.volmat@foss.st.com>
Link: https://patch.msgid.link/20251028-b4-drm-bridge-alloc-add-before-attach-v3-1-bb8611acbbfb@bootlin.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
drivers/gpu/drm/sti/sti_hda.c

index 2c015f563de96ae58959801493ead870c49f70e5..b7397827889c94d6f8e8c2a48b09f06e29ceeaf7 100644 (file)
@@ -779,6 +779,8 @@ static int sti_hda_probe(struct platform_device *pdev)
                return PTR_ERR(hda->clk_hddac);
        }
 
+       drm_bridge_add(&hda->bridge);
+
        platform_set_drvdata(pdev, hda);
 
        return component_add(&pdev->dev, &sti_hda_ops);
@@ -786,7 +788,10 @@ static int sti_hda_probe(struct platform_device *pdev)
 
 static void sti_hda_remove(struct platform_device *pdev)
 {
+       struct sti_hda *hda = platform_get_drvdata(pdev);
+
        component_del(&pdev->dev, &sti_hda_ops);
+       drm_bridge_remove(&hda->bridge);
 }
 
 static const struct of_device_id hda_of_match[] = {