media: anysee: Fix and remove outdated comment

anysee driver was transformed to use usbv2 years ago. The comments in
anysee_ctrl_msg() still are referencing the old interfaces where msleep()
was used. The v2 interfaces also changed over the years and with commit
1162c7b383a6 ("[media] dvb_usb_v2: refactor dvb_usbv2_generic_rw()") the
usage of msleep() was gone anyway.

Remove FIXME comment and update also comment before call to
dvb_usbv2_generic_rw_locked().

Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/all/20241014-devel-anna-maria-b4-timers-flseep-v3-14-dc8b907cb62f@linutronix.de

diff --git a/drivers/media/usb/dvb-usb-v2/anysee.c b/drivers/media/usb/dvb-usb-v2/anysee.c
index 8699846eb4162c6e0ff0e4784acfcab305108103..bea12cdc85e8ba576182a139e7533985fc26c5c5 100644 (file)
--- a/drivers/media/usb/dvb-usb-v2/anysee.c
+++ b/drivers/media/usb/dvb-usb-v2/anysee.c
@@ -46,24 +46,15 @@ static int anysee_ctrl_msg(struct dvb_usb_device *d,
 
        dev_dbg(&d->udev->dev, "%s: >>> %*ph\n", __func__, slen, state->buf);
 
-       /* We need receive one message more after dvb_usb_generic_rw due
-          to weird transaction flow, which is 1 x send + 2 x receive. */
+       /*
+        * We need receive one message more after dvb_usbv2_generic_rw_locked()
+        * due to weird transaction flow, which is 1 x send + 2 x receive.
+        */
        ret = dvb_usbv2_generic_rw_locked(d, state->buf, sizeof(state->buf),
                        state->buf, sizeof(state->buf));
        if (ret)
                goto error_unlock;
 
-       /* TODO FIXME: dvb_usb_generic_rw() fails rarely with error code -32
-        * (EPIPE, Broken pipe). Function supports currently msleep() as a
-        * parameter but I would not like to use it, since according to
-        * Documentation/timers/timers-howto.rst it should not be used such
-        * short, under < 20ms, sleeps. Repeating failed message would be
-        * better choice as not to add unwanted delays...
-        * Fixing that correctly is one of those or both;
-        * 1) use repeat if possible
-        * 2) add suitable delay
-        */
-
        /* get answer, retry few times if error returned */
        for (i = 0; i < 3; i++) {
                /* receive 2nd answer */