]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
Fixes for 5.4
authorSasha Levin <sashal@kernel.org>
Sun, 7 Mar 2021 23:08:22 +0000 (18:08 -0500)
committerSasha Levin <sashal@kernel.org>
Sun, 7 Mar 2021 23:08:22 +0000 (18:08 -0500)
Signed-off-by: Sasha Levin <sashal@kernel.org>
queue-5.4/alsa-ctxfi-cthw20k2-fix-mask-on-conf-to-allow-4-bits.patch [new file with mode: 0644]
queue-5.4/alsa-hda-intel-nhlt-verify-config-type.patch [new file with mode: 0644]
queue-5.4/ftrace-have-recordmcount-use-w8-to-read-relp-r_info-.patch [new file with mode: 0644]
queue-5.4/ib-mlx5-add-missing-error-code.patch [new file with mode: 0644]
queue-5.4/rdma-rxe-fix-missing-kconfig-dependency-on-crypto.patch [new file with mode: 0644]
queue-5.4/rsxx-return-efault-if-copy_to_user-fails.patch [new file with mode: 0644]
queue-5.4/series

diff --git a/queue-5.4/alsa-ctxfi-cthw20k2-fix-mask-on-conf-to-allow-4-bits.patch b/queue-5.4/alsa-ctxfi-cthw20k2-fix-mask-on-conf-to-allow-4-bits.patch
new file mode 100644 (file)
index 0000000..bf439e3
--- /dev/null
@@ -0,0 +1,46 @@
+From 83eb91f9c96cd1e1d99889aa872a625154b9a6b6 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Sat, 27 Feb 2021 00:15:27 +0000
+Subject: ALSA: ctxfi: cthw20k2: fix mask on conf to allow 4 bits
+
+From: Colin Ian King <colin.king@canonical.com>
+
+[ Upstream commit 26a9630c72ebac7c564db305a6aee54a8edde70e ]
+
+Currently the mask operation on variable conf is just 3 bits so
+the switch statement case value of 8 is unreachable dead code.
+The function daio_mgr_dao_init can be passed a 4 bit value,
+function dao_rsc_init calls it with conf set to:
+
+     conf = (desc->msr & 0x7) | (desc->passthru << 3);
+
+so clearly when desc->passthru is set to 1 then conf can be
+at least 8.
+
+Fix this by changing the mask to 0xf.
+
+Fixes: 8cc72361481f ("ALSA: SB X-Fi driver merge")
+Signed-off-by: Colin Ian King <colin.king@canonical.com>
+Link: https://lore.kernel.org/r/20210227001527.1077484-1-colin.king@canonical.com
+Signed-off-by: Takashi Iwai <tiwai@suse.de>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ sound/pci/ctxfi/cthw20k2.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/sound/pci/ctxfi/cthw20k2.c b/sound/pci/ctxfi/cthw20k2.c
+index 3cd4b7dad945..b1cc4cdc6c41 100644
+--- a/sound/pci/ctxfi/cthw20k2.c
++++ b/sound/pci/ctxfi/cthw20k2.c
+@@ -991,7 +991,7 @@ static int daio_mgr_dao_init(void *blk, unsigned int idx, unsigned int conf)
+       if (idx < 4) {
+               /* S/PDIF output */
+-              switch ((conf & 0x7)) {
++              switch ((conf & 0xf)) {
+               case 1:
+                       set_field(&ctl->txctl[idx], ATXCTL_NUC, 0);
+                       break;
+-- 
+2.30.1
+
diff --git a/queue-5.4/alsa-hda-intel-nhlt-verify-config-type.patch b/queue-5.4/alsa-hda-intel-nhlt-verify-config-type.patch
new file mode 100644 (file)
index 0000000..26f58ca
--- /dev/null
@@ -0,0 +1,143 @@
+From 365ec48964d9074fffcc31566fea0dcc8bdd5bec Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Mon, 1 Mar 2021 18:01:46 -0600
+Subject: ALSA: hda: intel-nhlt: verify config type
+
+From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
+
+[ Upstream commit a864e8f159b13babf552aff14a5fbe11abc017e4 ]
+
+Multiple bug reports report issues with the SOF and SST drivers when
+dealing with single microphone cases.
+
+We currently read the DMIC array information unconditionally but we
+don't check that the configuration type is actually a mic array.
+
+When the DMIC link does not rely on a mic array configuration, the
+recommendation is to check the format information to infer the maximum
+number of channels, and map this to the number of microphones.
+
+This leaves a potential for a mismatch between actual microphones
+available in hardware and what the ACPI table contains, but we have no
+other source of information.
+
+Note that single microphone configurations can alternatively be
+handled with a 'mic array' configuration along with a 'vendor-defined'
+geometry.
+
+Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=201251
+BugLink: https://github.com/thesofproject/linux/issues/2725
+Fixes: 7a33ea70e1868 ('ALSA: hda: intel-nhlt: handle NHLT VENDOR_DEFINED DMIC geometry')
+Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
+Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@intel.com>
+Reviewed-by: Rander Wang <rander.wang@intel.com>
+Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
+Link: https://lore.kernel.org/r/20210302000146.1177770-1-pierre-louis.bossart@linux.intel.com
+Signed-off-by: Takashi Iwai <tiwai@suse.de>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ include/sound/intel-nhlt.h |  5 ++++
+ sound/hda/intel-nhlt.c     | 54 +++++++++++++++++++++++++++++++-------
+ 2 files changed, 50 insertions(+), 9 deletions(-)
+
+diff --git a/include/sound/intel-nhlt.h b/include/sound/intel-nhlt.h
+index f657fd8fc0ad..f38947b9a1b9 100644
+--- a/include/sound/intel-nhlt.h
++++ b/include/sound/intel-nhlt.h
+@@ -112,6 +112,11 @@ struct nhlt_vendor_dmic_array_config {
+       /* TODO add vendor mic config */
+ } __packed;
++enum {
++      NHLT_CONFIG_TYPE_GENERIC = 0,
++      NHLT_CONFIG_TYPE_MIC_ARRAY = 1
++};
++
+ enum {
+       NHLT_MIC_ARRAY_2CH_SMALL = 0xa,
+       NHLT_MIC_ARRAY_2CH_BIG = 0xb,
+diff --git a/sound/hda/intel-nhlt.c b/sound/hda/intel-nhlt.c
+index daede96f28ee..baeda6c9716a 100644
+--- a/sound/hda/intel-nhlt.c
++++ b/sound/hda/intel-nhlt.c
+@@ -64,18 +64,44 @@ int intel_nhlt_get_dmic_geo(struct device *dev, struct nhlt_acpi_table *nhlt)
+       struct nhlt_endpoint *epnt;
+       struct nhlt_dmic_array_config *cfg;
+       struct nhlt_vendor_dmic_array_config *cfg_vendor;
++      struct nhlt_fmt *fmt_configs;
+       unsigned int dmic_geo = 0;
+-      u8 j;
++      u16 max_ch = 0;
++      u8 i, j;
+       if (!nhlt)
+               return 0;
+-      epnt = (struct nhlt_endpoint *)nhlt->desc;
++      for (j = 0, epnt = nhlt->desc; j < nhlt->endpoint_count; j++,
++           epnt = (struct nhlt_endpoint *)((u8 *)epnt + epnt->length)) {
+-      for (j = 0; j < nhlt->endpoint_count; j++) {
+-              if (epnt->linktype == NHLT_LINK_DMIC) {
+-                      cfg = (struct nhlt_dmic_array_config  *)
+-                                      (epnt->config.caps);
++              if (epnt->linktype != NHLT_LINK_DMIC)
++                      continue;
++
++              cfg = (struct nhlt_dmic_array_config  *)(epnt->config.caps);
++              fmt_configs = (struct nhlt_fmt *)(epnt->config.caps + epnt->config.size);
++
++              /* find max number of channels based on format_configuration */
++              if (fmt_configs->fmt_count) {
++                      dev_dbg(dev, "%s: found %d format definitions\n",
++                              __func__, fmt_configs->fmt_count);
++
++                      for (i = 0; i < fmt_configs->fmt_count; i++) {
++                              struct wav_fmt_ext *fmt_ext;
++
++                              fmt_ext = &fmt_configs->fmt_config[i].fmt_ext;
++
++                              if (fmt_ext->fmt.channels > max_ch)
++                                      max_ch = fmt_ext->fmt.channels;
++                      }
++                      dev_dbg(dev, "%s: max channels found %d\n", __func__, max_ch);
++              } else {
++                      dev_dbg(dev, "%s: No format information found\n", __func__);
++              }
++
++              if (cfg->device_config.config_type != NHLT_CONFIG_TYPE_MIC_ARRAY) {
++                      dmic_geo = max_ch;
++              } else {
+                       switch (cfg->array_type) {
+                       case NHLT_MIC_ARRAY_2CH_SMALL:
+                       case NHLT_MIC_ARRAY_2CH_BIG:
+@@ -92,13 +118,23 @@ int intel_nhlt_get_dmic_geo(struct device *dev, struct nhlt_acpi_table *nhlt)
+                               dmic_geo = cfg_vendor->nb_mics;
+                               break;
+                       default:
+-                              dev_warn(dev, "undefined DMIC array_type 0x%0x\n",
+-                                       cfg->array_type);
++                              dev_warn(dev, "%s: undefined DMIC array_type 0x%0x\n",
++                                       __func__, cfg->array_type);
++                      }
++
++                      if (dmic_geo > 0) {
++                              dev_dbg(dev, "%s: Array with %d dmics\n", __func__, dmic_geo);
++                      }
++                      if (max_ch > dmic_geo) {
++                              dev_dbg(dev, "%s: max channels %d exceed dmic number %d\n",
++                                      __func__, max_ch, dmic_geo);
+                       }
+               }
+-              epnt = (struct nhlt_endpoint *)((u8 *)epnt + epnt->length);
+       }
++      dev_dbg(dev, "%s: dmic number %d max_ch %d\n",
++              __func__, dmic_geo, max_ch);
++
+       return dmic_geo;
+ }
+ EXPORT_SYMBOL_GPL(intel_nhlt_get_dmic_geo);
+-- 
+2.30.1
+
diff --git a/queue-5.4/ftrace-have-recordmcount-use-w8-to-read-relp-r_info-.patch b/queue-5.4/ftrace-have-recordmcount-use-w8-to-read-relp-r_info-.patch
new file mode 100644 (file)
index 0000000..86e73ea
--- /dev/null
@@ -0,0 +1,56 @@
+From f2d6b07be181053a49c56c56bff100d1c46b663a Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Mon, 22 Feb 2021 13:58:40 +0000
+Subject: ftrace: Have recordmcount use w8 to read relp->r_info in
+ arm64_is_fake_mcount
+
+From: Chen Jun <chenjun102@huawei.com>
+
+[ Upstream commit 999340d51174ce4141dd723105d4cef872b13ee9 ]
+
+On little endian system, Use aarch64_be(gcc v7.3) downloaded from
+linaro.org to build image with CONFIG_CPU_BIG_ENDIAN = y,
+CONFIG_FTRACE = y, CONFIG_DYNAMIC_FTRACE = y.
+
+gcc will create symbols of _mcount but recordmcount can not create
+mcount_loc for *.o.
+aarch64_be-linux-gnu-objdump -r fs/namei.o | grep mcount
+00000000000000d0 R_AARCH64_CALL26  _mcount
+...
+0000000000007190 R_AARCH64_CALL26  _mcount
+
+The reason is than funciton arm64_is_fake_mcount can not work correctly.
+A symbol of _mcount in *.o compiled with big endian compiler likes:
+00 00 00 2d 00 00 01 1b
+w(rp->r_info) will return 0x2d instead of 0x011b. Because w() takes
+uint32_t as parameter, which truncates rp->r_info.
+
+Use w8() instead w() to read relp->r_info
+
+Link: https://lkml.kernel.org/r/20210222135840.56250-1-chenjun102@huawei.com
+
+Fixes: ea0eada45632 ("recordmcount: only record relocation of type R_AARCH64_CALL26 on arm64.")
+Acked-by: Will Deacon <will@kernel.org>
+Signed-off-by: Chen Jun <chenjun102@huawei.com>
+Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ scripts/recordmcount.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
+index b9c2ee7ab43f..cce12e1971d8 100644
+--- a/scripts/recordmcount.c
++++ b/scripts/recordmcount.c
+@@ -438,7 +438,7 @@ static int arm_is_fake_mcount(Elf32_Rel const *rp)
+ static int arm64_is_fake_mcount(Elf64_Rel const *rp)
+ {
+-      return ELF64_R_TYPE(w(rp->r_info)) != R_AARCH64_CALL26;
++      return ELF64_R_TYPE(w8(rp->r_info)) != R_AARCH64_CALL26;
+ }
+ /* 64-bit EM_MIPS has weird ELF64_Rela.r_info.
+-- 
+2.30.1
+
diff --git a/queue-5.4/ib-mlx5-add-missing-error-code.patch b/queue-5.4/ib-mlx5-add-missing-error-code.patch
new file mode 100644 (file)
index 0000000..31d6f0b
--- /dev/null
@@ -0,0 +1,40 @@
+From 19c2708d1c3bcf6f9cca024e906a06adc5340ed7 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Mon, 22 Feb 2021 20:23:43 +0800
+Subject: IB/mlx5: Add missing error code
+
+From: YueHaibing <yuehaibing@huawei.com>
+
+[ Upstream commit 3a9b3d4536e0c25bd3906a28c1f584177e49dd0f ]
+
+Set err to -ENOMEM if kzalloc fails instead of 0.
+
+Fixes: 759738537142 ("IB/mlx5: Enable subscription for device events over DEVX")
+Link: https://lore.kernel.org/r/20210222122343.19720-1-yuehaibing@huawei.com
+Signed-off-by: YueHaibing <yuehaibing@huawei.com>
+Acked-by: Leon Romanovsky <leonro@nvidia.com>
+Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ drivers/infiniband/hw/mlx5/devx.c | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/drivers/infiniband/hw/mlx5/devx.c b/drivers/infiniband/hw/mlx5/devx.c
+index 4d6f25fdcc0e..664e0f374ac0 100644
+--- a/drivers/infiniband/hw/mlx5/devx.c
++++ b/drivers/infiniband/hw/mlx5/devx.c
+@@ -2022,8 +2022,10 @@ static int UVERBS_HANDLER(MLX5_IB_METHOD_DEVX_SUBSCRIBE_EVENT)(
+               num_alloc_xa_entries++;
+               event_sub = kzalloc(sizeof(*event_sub), GFP_KERNEL);
+-              if (!event_sub)
++              if (!event_sub) {
++                      err = -ENOMEM;
+                       goto err;
++              }
+               list_add_tail(&event_sub->event_list, &sub_list);
+               if (use_eventfd) {
+-- 
+2.30.1
+
diff --git a/queue-5.4/rdma-rxe-fix-missing-kconfig-dependency-on-crypto.patch b/queue-5.4/rdma-rxe-fix-missing-kconfig-dependency-on-crypto.patch
new file mode 100644 (file)
index 0000000..642e867
--- /dev/null
@@ -0,0 +1,44 @@
+From 6ddbee8f4335c09fca0f2378c0e321111b2729aa Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Fri, 19 Feb 2021 18:32:26 -0500
+Subject: RDMA/rxe: Fix missing kconfig dependency on CRYPTO
+
+From: Julian Braha <julianbraha@gmail.com>
+
+[ Upstream commit 475f23b8c66d2892ad6acbf90ed757cafab13de7 ]
+
+When RDMA_RXE is enabled and CRYPTO is disabled, Kbuild gives the
+following warning:
+
+ WARNING: unmet direct dependencies detected for CRYPTO_CRC32
+   Depends on [n]: CRYPTO [=n]
+   Selected by [y]:
+   - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && INFINIBAND_VIRT_DMA [=y]
+
+This is because RDMA_RXE selects CRYPTO_CRC32, without depending on or
+selecting CRYPTO, despite that config option being subordinate to CRYPTO.
+
+Fixes: cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible")
+Signed-off-by: Julian Braha <julianbraha@gmail.com>
+Link: https://lore.kernel.org/r/21525878.NYvzQUHefP@ubuntu-mate-laptop
+Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ drivers/infiniband/sw/rxe/Kconfig | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/drivers/infiniband/sw/rxe/Kconfig b/drivers/infiniband/sw/rxe/Kconfig
+index 71a773f607bb..0e8f1d05dfb2 100644
+--- a/drivers/infiniband/sw/rxe/Kconfig
++++ b/drivers/infiniband/sw/rxe/Kconfig
+@@ -4,6 +4,7 @@ config RDMA_RXE
+       depends on INET && PCI && INFINIBAND
+       depends on INFINIBAND_VIRT_DMA
+       select NET_UDP_TUNNEL
++      select CRYPTO
+       select CRYPTO_CRC32
+       select DMA_VIRT_OPS
+       ---help---
+-- 
+2.30.1
+
diff --git a/queue-5.4/rsxx-return-efault-if-copy_to_user-fails.patch b/queue-5.4/rsxx-return-efault-if-copy_to_user-fails.patch
new file mode 100644 (file)
index 0000000..86510d2
--- /dev/null
@@ -0,0 +1,50 @@
+From 5dcc5727f289986295b88045be301fab009dac6e Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Wed, 3 Mar 2021 13:59:12 +0300
+Subject: rsxx: Return -EFAULT if copy_to_user() fails
+
+From: Dan Carpenter <dan.carpenter@oracle.com>
+
+[ Upstream commit 77516d25f54912a7baedeeac1b1b828b6f285152 ]
+
+The copy_to_user() function returns the number of bytes remaining but
+we want to return -EFAULT to the user if it can't complete the copy.
+The "st" variable only holds zero on success or negative error codes on
+failure so the type should be int.
+
+Fixes: 36f988e978f8 ("rsxx: Adding in debugfs entries.")
+Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
+Signed-off-by: Jens Axboe <axboe@kernel.dk>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ drivers/block/rsxx/core.c | 8 +++++---
+ 1 file changed, 5 insertions(+), 3 deletions(-)
+
+diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c
+index 10f6368117d8..804d28faa97b 100644
+--- a/drivers/block/rsxx/core.c
++++ b/drivers/block/rsxx/core.c
+@@ -165,15 +165,17 @@ static ssize_t rsxx_cram_read(struct file *fp, char __user *ubuf,
+ {
+       struct rsxx_cardinfo *card = file_inode(fp)->i_private;
+       char *buf;
+-      ssize_t st;
++      int st;
+       buf = kzalloc(cnt, GFP_KERNEL);
+       if (!buf)
+               return -ENOMEM;
+       st = rsxx_creg_read(card, CREG_ADD_CRAM + (u32)*ppos, cnt, buf, 1);
+-      if (!st)
+-              st = copy_to_user(ubuf, buf, cnt);
++      if (!st) {
++              if (copy_to_user(ubuf, buf, cnt))
++                      st = -EFAULT;
++      }
+       kfree(buf);
+       if (st)
+               return st;
+-- 
+2.30.1
+
index eade066beecade12a66e6ce2b893aeeab56a37d3..e959ddbab4d796035db22382e972591d59e46695 100644 (file)
@@ -13,3 +13,9 @@ drm-amdgpu-fix-parameter-error-of-rreg32_pcie-in-amdgpu_regs_pcie.patch
 arm64-ptrace-fix-seccomp-of-traced-syscall-1-no_syscall.patch
 crypto-shash-reduce-minimum-alignment-of-shash_desc-structure.patch
 usbip-tools-fix-build-error-for-multiple-definition.patch
+alsa-ctxfi-cthw20k2-fix-mask-on-conf-to-allow-4-bits.patch
+rdma-rxe-fix-missing-kconfig-dependency-on-crypto.patch
+ib-mlx5-add-missing-error-code.patch
+alsa-hda-intel-nhlt-verify-config-type.patch
+ftrace-have-recordmcount-use-w8-to-read-relp-r_info-.patch
+rsxx-return-efault-if-copy_to_user-fails.patch