BUG/MINOR: quic: loss time limit variable computed but not used

<loss_time_limit> is the loss time limit computed from <time_sent> packet
transmission timestamps in qc_packet_loss_lookup() to identify the packets which
have been lost. This latter timestamp variable was used in place of
<loss_time_limit> to distinguish such packets from others (still in fly packets).

Must be backported to 2.6

diff --git a/src/quic_loss.c b/src/quic_loss.c
index 72f5a28ea327a60b4d126a4611c416428e94eafd..7cce3a4788770f3911d2ac45a68ad86499f5a47e 100644 (file)
--- a/src/quic_loss.c
+++ b/src/quic_loss.c
@@ -173,7 +173,7 @@ void qc_packet_loss_lookup(struct quic_pktns *pktns, struct quic_conn *qc,
 
                time_sent = pkt->time_sent;
                loss_time_limit = tick_add(time_sent, loss_delay);
-               if (tick_is_le(time_sent, now_ms) ||
+               if (tick_is_le(loss_time_limit, now_ms) ||
                        (int64_t)largest_acked_pn >= pkt->pn_node.key + QUIC_LOSS_PACKET_THRESHOLD) {
                        eb64_delete(&pkt->pn_node);
                        LIST_APPEND(lost_pkts, &pkt->list);