strip: Always check gelf_update results.

Signed-off-by: Mark Wielaard <mark@klomp.org>

diff --git a/src/ChangeLog b/src/ChangeLog
index 698b3c77c8d0ebebc18ed9751a1cb3f251db9336..9d4ce31d2547b1630109db28fa5fb02a8cb1aa30 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,8 @@
+2021-06-18  Mark Wielaard  <mark@klomp.org>
+
+       * strip.c (remove_debug_relocations): Check gelf_update results.
+       (update_section_size): Likewise.
+
 2021-06-06  Sergei Trofimovich  <slyfox@gentoo.org>
 
        * elflint.c (buffer_left): Mark as 'static' to avoid external linkage

diff --git a/src/strip.c b/src/strip.c
index 70fc8c03e9310e4636af845caa7c6217fcebf5ce..961b9db58fd403e627888cc47752768075cc1d57 100644 (file)
--- a/src/strip.c
+++ b/src/strip.c
@@ -705,17 +705,21 @@ remove_debug_relocations (Ebl *ebl, Elf *elf, GElf_Ehdr *ehdr,
 relocate_failed:
              if (relidx != next)
                {
+                 int updated;
                  if (is_rela)
-                   gelf_update_rela (reldata, next, rel_p);
+                   updated = gelf_update_rela (reldata, next, rel_p);
                  else
-                   gelf_update_rel (reldata, next, rel_p);
+                   updated = gelf_update_rel (reldata, next, rel_p);
+                 if (updated == 0)
+                   INTERNAL_ERROR (fname);
                }
              ++next;
            }
 
          nrels = next;
          shdr->sh_size = reldata->d_size = nrels * shdr->sh_entsize;
-         gelf_update_shdr (scn, shdr);
+         if (gelf_update_shdr (scn, shdr) == 0)
+           INTERNAL_ERROR (fname);
 
          if (is_gnu_compressed)
            {
@@ -952,7 +956,8 @@ update_section_size (Elf_Scn *scn,
   GElf_Shdr shdr_mem;
   GElf_Shdr *shdr = gelf_getshdr (scn, &shdr_mem);
   shdr->sh_size = newdata->d_size;
-  (void) gelf_update_shdr (scn, shdr);
+  if (gelf_update_shdr (scn, shdr) == 0)
+    INTERNAL_ERROR (fname);
   if (debugelf != NULL)
     {
       /* libelf will use d_size to set sh_size.  */