]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
power: supply: rt5033: Bring back i2c_set_clientdata
authorNikita Travkin <nikita@trvn.ru>
Wed, 5 Jun 2024 13:53:27 +0000 (18:53 +0500)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Wed, 5 Jun 2024 21:38:31 +0000 (23:38 +0200)
Commit 3a93da231c12 ("power: supply: rt5033: Use devm_power_supply_register() helper")
reworked the driver to use devm. While at it, the i2c_set_clientdata
was dropped along with the remove callback. Unfortunately other parts
of the driver also rely on i2c clientdata so this causes kernel oops.

Bring the call back to fix the driver.

Fixes: 3a93da231c12 ("power: supply: rt5033: Use devm_power_supply_register() helper")
Tested-by: Raymond Hackley <raymondhackley@protonmail.com>
Signed-off-by: Nikita Travkin <nikita@trvn.ru>
Link: https://lore.kernel.org/r/20240605-rt5033-null-clientdata-v1-1-558d710eeb4d@trvn.ru
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/rt5033_battery.c

index 32eafe2c00af5177e0db8a31eab0d8d892e0d86c..7a27b262fb84a73db82b12e97c2fb57162709e14 100644 (file)
@@ -159,6 +159,7 @@ static int rt5033_battery_probe(struct i2c_client *client)
                return -EINVAL;
        }
 
+       i2c_set_clientdata(client, battery);
        psy_cfg.of_node = client->dev.of_node;
        psy_cfg.drv_data = battery;