]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: proximity: hx9023s: Fix error code in hx9023s_property_get()
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 12 Aug 2024 06:43:05 +0000 (09:43 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 17 Aug 2024 14:37:37 +0000 (15:37 +0100)
If we're returning because "reg >= HX9023S_CH_NUM" then set the error code
to -ENIVAL instead of success.

Fixes: 60df548277b7 ("iio: proximity: Add driver support for TYHX's HX9023S capacitive proximity sensor")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/49b5a9bc-e5ca-43a7-a665-313eb06fbe27@stanley.mountain
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/proximity/hx9023s.c

index fe14a62a13428618891b4df930993dcbb01eaea1..8b9f84400e004c9921fd68dba042afc543c9feab 100644 (file)
@@ -598,7 +598,8 @@ static int hx9023s_property_get(struct hx9023s_data *data)
        device_for_each_child_node_scoped(dev, child) {
                ret = fwnode_property_read_u32(child, "reg", &reg);
                if (ret || reg >= HX9023S_CH_NUM)
-                       return dev_err_probe(dev, ret, "Failed to read reg\n");
+                       return dev_err_probe(dev, ret < 0 ? ret : -EINVAL,
+                                            "Failed to read reg\n");
                __set_bit(reg, &data->chan_in_use);
 
                ret = fwnode_property_read_u32(child, "single-channel", &temp);