cifsd: simplify error handling in ksmbd_gen_preauth_integrity_hash()

Simplify error handling in ksmbd_gen_preauth_integrity_hash().

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/cifsd/auth.c b/fs/cifsd/auth.c
index b0a9e4591fa55021a41b55f939ce6ae6bc08cdbf..1d4c4e6d28cd836fd134f76b2d7513a329da34cd 100644 (file)
--- a/fs/cifsd/auth.c
+++ b/fs/cifsd/auth.c
@@ -1063,14 +1063,13 @@ int ksmbd_gen_preauth_integrity_hash(struct ksmbd_conn *conn, char *buf,
        int msg_size = be32_to_cpu(rcv_hdr->smb2_buf_length);
        struct ksmbd_crypto_ctx *ctx = NULL;
 
-       if (conn->preauth_info->Preauth_HashId ==
-           SMB2_PREAUTH_INTEGRITY_SHA512) {
-               ctx = ksmbd_crypto_ctx_find_sha512();
-               if (!ctx) {
-                       ksmbd_debug(AUTH, "could not alloc sha512 rc %d\n", rc);
-                       goto out;
-               }
-       } else {
+       if (conn->preauth_info->Preauth_HashId !=
+           SMB2_PREAUTH_INTEGRITY_SHA512)
+               return -EINVAL;
+
+       ctx = ksmbd_crypto_ctx_find_sha512();
+       if (!ctx) {
+               ksmbd_debug(AUTH, "could not alloc sha512 rc %d\n", rc);
                goto out;
        }