]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
gdb, testsuite: Fix return value in gdb.base/foll-fork.exp
authorFelix Willgerodt <felix.willgerodt@intel.com>
Tue, 21 May 2024 07:20:39 +0000 (09:20 +0200)
committerFelix Willgerodt <felix.willgerodt@intel.com>
Thu, 23 May 2024 06:19:48 +0000 (08:19 +0200)
In a remote testing setup, I saw this error:

~~~
(gdb) FAIL: gdb.base/foll-fork.exp: check_fork_catchpoints: runto: run to main
ERROR: tcl error sourcing gdb/gdb/testsuite/gdb.base/foll-fork.exp.
ERROR: expected boolean value but got ""
    while executing
"if { ![check_fork_catchpoints] } {
    untested "follow-fork not supported"
    return
}"
    (file "gdb/gdb/testsuite/gdb.base/foll-fork.exp" line 434)
    invoked from within
"source gdb/gdb/testsuite/gdb.base/foll-fork.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source gdb/gdb/testsuite/gdb.base/foll-fork.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name""
Remote debugging from host 172.0.1.3, port 37766
Killing process(es): 1171
Quit
~~~

The actual reason for this were some connection problems. Though the
function check_fork_catchpoints shouldn't return an empty string, especially
as it promises to always return 0 or 1. Fix that.

Approved-By: Tom Tromey <tom@tromey.com>
gdb/testsuite/gdb.base/foll-fork.exp

index ecf2111d4fdc067c9252c7a25cdce0c03c6f0609..0d801f004e476a6731332a9b310bf5b0026cc4d9 100644 (file)
@@ -42,7 +42,7 @@ proc_with_prefix check_fork_catchpoints {} {
   global gdb_prompt
 
   if { ![setup] } {
-      return
+      return 0
   }
 
   # Verify that the system supports "catch fork".