]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: usb: aqc111: debug info before sanitation
authorOliver Neukum <oneukum@suse.com>
Wed, 28 May 2025 11:03:54 +0000 (13:03 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 May 2025 11:14:53 +0000 (12:14 +0100)
If we sanitize error returns, the debug statements need
to come before that so that we don't lose information.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Fixes: 405b0d610745 ("net: usb: aqc111: fix error handling of usbnet read calls")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/aqc111.c

index 453a2cf82753fb16ab5398a2991c36206389a791..9201ee10a13f785ae8df0d45489c05ed712f17c8 100644 (file)
@@ -31,11 +31,11 @@ static int aqc111_read_cmd_nopm(struct usbnet *dev, u8 cmd, u16 value,
                                   USB_RECIP_DEVICE, value, index, data, size);
 
        if (unlikely(ret < size)) {
-               ret = ret < 0 ? ret : -ENODATA;
-
                netdev_warn(dev->net,
                            "Failed to read(0x%x) reg index 0x%04x: %d\n",
                            cmd, index, ret);
+
+               ret = ret < 0 ? ret : -ENODATA;
        }
 
        return ret;
@@ -50,11 +50,11 @@ static int aqc111_read_cmd(struct usbnet *dev, u8 cmd, u16 value,
                              USB_RECIP_DEVICE, value, index, data, size);
 
        if (unlikely(ret < size)) {
-               ret = ret < 0 ? ret : -ENODATA;
-
                netdev_warn(dev->net,
                            "Failed to read(0x%x) reg index 0x%04x: %d\n",
                            cmd, index, ret);
+
+               ret = ret < 0 ? ret : -ENODATA;
        }
 
        return ret;