]> git.ipfire.org Git - thirdparty/openssh-portable.git/commitdiff
Import fmt_scaled.c rev 1.14 from OpenBSD.
authorDarren Tucker <dtucker@zip.com.au>
Wed, 29 Mar 2017 05:32:57 +0000 (16:32 +1100)
committerDarren Tucker <dtucker@zip.com.au>
Wed, 29 Mar 2017 05:32:57 +0000 (16:32 +1100)
Catch integer underflow in scan_scaled reported by Nicolas Iooss.
ok deraadt@ djm@

openbsd-compat/fmt_scaled.c

index e5533b2de90ce09ba95e3930caa2fcc202efe846..7e6a57d45e9639f44d07b7296a1f44935f65691c 100644 (file)
@@ -1,4 +1,4 @@
-/*     $OpenBSD: fmt_scaled.c,v 1.13 2017/03/11 23:37:23 djm Exp $     */
+/*     $OpenBSD: fmt_scaled.c,v 1.14 2017/03/15 00:13:18 dtucker Exp $ */
 
 /*
  * Copyright (c) 2001, 2002, 2003 Ian F. Darwin.  All rights reserved.
@@ -175,6 +175,11 @@ scan_scaled(char *scaled, long long *result)
                                return -1;
                        }
 
+                       if (whole <= LLONG_MIN / scale_fact) {
+                               errno = ERANGE;
+                               return -1;
+                       }
+
                        /* scale whole part */
                        whole *= scale_fact;