]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Fix basic_pop3_auth startup errors (#284)
authorAndreas Hasenack <panlinux@gmail.com>
Mon, 10 Sep 2018 19:40:55 +0000 (19:40 +0000)
committerSquid Anubis <squid-anubis@squid-cache.org>
Wed, 12 Sep 2018 19:41:30 +0000 (19:41 +0000)
90cf12e added "use strict" which requires declaring all variables.

Originally reported (against Squid v3) at
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1755189

src/auth/basic/POP3/basic_pop3_auth.pl.in

index f821f62e9c4a48d012e09b6c12ea08dc630a2308..5ba458bbf5a914ae97f511aa5c02a373e18daa17 100755 (executable)
@@ -89,14 +89,14 @@ if ( @ARGV != 1 ) {
     exit 1
 }
 
-$server = shift @ARGV;
+my $server = shift @ARGV;
 
 while(<>) {
     my ($username, $password) = split(/\s+/);
     $username =~ s/%([0-9a-f][0-9a-f])/pack("H2",$1)/gie;
     $password =~ s/%([0-9a-f][0-9a-f])/pack("H2",$1)/gie;
 
-    $pop = Net::POP3->new($server);
+    my $pop = Net::POP3->new($server);
     if (!$pop) {
        print "ERR Server not responding\n";
        next;