Fix PR 12028: "GDB crashes on a double free during overload resolution "

2010-09-23  Sami Wagiaalla  <swagiaal@redhat.com>

	PR C++/12028
	* valops.c (find_oload_champ_namespace_loop): removed incorrect
	'old_cleanups' reassignment.

2010-09-23  Sami Wagiaalla  <swagiaal@redhat.com>

	* gdb.cp/pr12028.cc: New.
	* gdb.cp/pr12028.exp: New.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 48db57812d013f5e8173f57348129799ffd58c04..b9ebe527de7ccb27f51433362d4263503b736cdd 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2010-09-23  Sami Wagiaalla  <swagiaal@redhat.com>
+
+       PR C++/12028
+       * valops.c (find_oload_champ_namespace_loop): removed incorrect
+       'old_cleanups' reassignment.
+
 2010-09-08  Yao Qi  <yao@codesourcery.com>
            Pedro Alves  <pedro@codesourcery.com>
 

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 8f81444b620be47fa3f5079dd73d146574f7d1dc..d75cb9f3b68628d32469c973b8ee65d7e06ca585 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2010-09-23  Sami Wagiaalla  <swagiaal@redhat.com>
+
+       * gdb.cp/pr12028.cc: New.
+       * gdb.cp/pr12028.exp: New.
+
 2010-08-26  Yao Qi  <yao@codesourcery.com>
 
        * gdb.dwarf2/dw2-ref-missing-frame-func.c: Add .p2align 4 for labels

diff --git a/gdb/valops.c b/gdb/valops.c
index 7fbad10ce34db9c386e84bdf0b1d87f447be46a6..4e83a04723a43f0856885b573000632a91517f21 100644 (file)
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -2715,7 +2715,7 @@ find_oload_champ_namespace_loop (struct type **arg_types, int nargs,
      function symbol to start off with.)  */
 
   old_cleanups = make_cleanup (xfree, *oload_syms);
-  old_cleanups = make_cleanup (xfree, *oload_champ_bv);
+  make_cleanup (xfree, *oload_champ_bv);
   new_namespace = alloca (namespace_len + 1);
   strncpy (new_namespace, qualified_name, namespace_len);
   new_namespace[namespace_len] = '\0';