igc: drop unnecessary constant casts to u16

Remove unnecessary casts of constant values to u16.
C's integer promotion rules make them ints no matter what.

Signed-off-by: Jacek Kowalski <jacek@jacekk.info>
Suggested-by: Simon Horman <horms@kernel.org>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

diff --git a/drivers/net/ethernet/intel/igc/igc_i225.c b/drivers/net/ethernet/intel/igc/igc_i225.c
index 0dd61719f1edc403cb6ce7d0a19ea13d3a4d8910..5226d10cc95b0417172169f8fb66344a7c6ba1ae 100644 (file)
--- a/drivers/net/ethernet/intel/igc/igc_i225.c
+++ b/drivers/net/ethernet/intel/igc/igc_i225.c
@@ -435,7 +435,7 @@ static s32 igc_update_nvm_checksum_i225(struct igc_hw *hw)
                }
                checksum += nvm_data;
        }
-       checksum = (u16)NVM_SUM - checksum;
+       checksum = NVM_SUM - checksum;
        ret_val = igc_write_nvm_srwr(hw, NVM_CHECKSUM_REG, 1,
                                     &checksum);
        if (ret_val) {

diff --git a/drivers/net/ethernet/intel/igc/igc_nvm.c b/drivers/net/ethernet/intel/igc/igc_nvm.c
index efd121c0396705e24ec1c5841420413f6d5b96a0..a47b8d39238c23573e9e11cbc7af08a139481eb9 100644 (file)
--- a/drivers/net/ethernet/intel/igc/igc_nvm.c
+++ b/drivers/net/ethernet/intel/igc/igc_nvm.c
@@ -123,7 +123,7 @@ s32 igc_validate_nvm_checksum(struct igc_hw *hw)
                checksum += nvm_data;
        }
 
-       if (checksum != (u16)NVM_SUM) {
+       if (checksum != NVM_SUM) {
                hw_dbg("NVM Checksum Invalid\n");
                ret_val = -IGC_ERR_NVM;
                goto out;
@@ -155,7 +155,7 @@ s32 igc_update_nvm_checksum(struct igc_hw *hw)
                }
                checksum += nvm_data;
        }
-       checksum = (u16)NVM_SUM - checksum;
+       checksum = NVM_SUM - checksum;
        ret_val = hw->nvm.ops.write(hw, NVM_CHECKSUM_REG, 1, &checksum);
        if (ret_val)
                hw_dbg("NVM Write Error while updating checksum.\n");