]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
regulator: qcom-smd: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 14 Aug 2024 15:04:10 +0000 (17:04 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 14 Aug 2024 17:21:47 +0000 (18:21 +0100)
Use scoped for_each_available_child_of_node_scoped() when iterating over
device nodes to make code a bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20240814-cleanup-h-of-node-put-regulator-v1-6-87151088b883@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/qcom_smd-regulator.c

index 3b7e06b9f5ce96c7ce954fb2009ec24353d0aebe..6761ada0cf7d2c25f610659c48408cbe685815f9 100644 (file)
@@ -1435,7 +1435,6 @@ static int rpm_reg_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        const struct rpm_regulator_data *vreg_data;
-       struct device_node *node;
        struct qcom_rpm_reg *vreg;
        struct qcom_smd_rpm *rpm;
        int ret;
@@ -1455,18 +1454,14 @@ static int rpm_reg_probe(struct platform_device *pdev)
        if (!vreg_data)
                return -ENODEV;
 
-       for_each_available_child_of_node(dev->of_node, node) {
+       for_each_available_child_of_node_scoped(dev->of_node, node) {
                vreg = devm_kzalloc(&pdev->dev, sizeof(*vreg), GFP_KERNEL);
-               if (!vreg) {
-                       of_node_put(node);
+               if (!vreg)
                        return -ENOMEM;
-               }
 
                ret = rpm_regulator_init_vreg(vreg, dev, node, vreg_data);
-               if (ret < 0) {
-                       of_node_put(node);
+               if (ret < 0)
                        return ret;
-               }
        }
 
        return 0;