]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
nsswitch/libwbclient: Fix CID #1034862 Resource leak
authorGünther Deschner <gd@samba.org>
Mon, 18 Aug 2025 15:14:00 +0000 (17:14 +0200)
committerAnoop C S <anoopcs@samba.org>
Tue, 19 Aug 2025 09:45:46 +0000 (09:45 +0000)
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Tue Aug 19 09:45:46 UTC 2025 on atb-devel-224

nsswitch/libwbclient/tests/wbclient.c

index 0238ad69ec755932ad0d3f9cc33f9deb0a825e7d..a58e65023da06f6dba3cfc8a950db8c3426c0655 100644 (file)
@@ -231,16 +231,18 @@ static bool test_wbc_sidtostring(struct torture_context *tctx)
        struct wbcDomainSid sid;
        const char *sid_string = "S-1-5-32";
        char *sid_string2;
+       bool ret = true;
 
        torture_assert_wbc_ok(tctx, wbcStringToSid(sid_string, &sid),
                              "wbcStringToSid of %s failed", sid_string);
        torture_assert_wbc_ok(tctx, wbcSidToString(&sid, &sid_string2),
                              "wbcSidToString of %s failed", sid_string);
-       torture_assert_str_equal(tctx, sid_string, sid_string2,
+       torture_assert_str_equal_goto(tctx, sid_string, sid_string2, ret, done,
                "sid strings differ");
+ done:
        wbcFreeMemory(sid_string2);
 
-       return true;
+       return ret;
 }
 
 static bool test_wbc_guidtostring(struct torture_context *tctx)