test-bundle-uri: drop unused variables

Commit 70b9c10373 (bundle-uri client: add helper for testing server,
2022-12-22) added a cmd_ls_remote() function which contains "uploadpack"
and "server_options" variables. Neither of these variables is ever
modified after being initialized, so the code to handle non-NULL and
non-empty values is impossible to reach.

While in theory we might add command-line parsing to set these, let's
drop the dead code for now in the name of cleanliness. It's easy enough
to add it back later if need be.

Noticed by Coverity.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/helper/test-bundle-uri.c b/t/helper/test-bundle-uri.c
index 5df5bc3b89e04a9893518fc8cb5fe9158f24578c..b18e7603103817b931acf6ab2a8cbbae8538bb8e 100644 (file)
--- a/t/helper/test-bundle-uri.c
+++ b/t/helper/test-bundle-uri.c
@@ -76,8 +76,6 @@ usage:
 
 static int cmd_ls_remote(int argc, const char **argv)
 {
-       const char *uploadpack = NULL;
-       struct string_list server_options = STRING_LIST_INIT_DUP;
        const char *dest;
        struct remote *remote;
        struct transport *transport;
@@ -95,11 +93,6 @@ static int cmd_ls_remote(int argc, const char **argv)
                die(_("remote '%s' has no configured URL"), dest);
 
        transport = transport_get(remote, NULL);
-       if (uploadpack)
-               transport_set_option(transport, TRANS_OPT_UPLOADPACK, uploadpack);
-       if (server_options.nr)
-               transport->server_options = &server_options;
-
        if (transport_get_remote_bundle_uri(transport) < 0) {
                error(_("could not get the bundle-uri list"));
                status = 1;