]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: libsmb: Cleanup - use helper 'ok' bool for resolve_hosts().
authorJeremy Allison <jra@samba.org>
Tue, 21 Jul 2020 00:02:15 +0000 (17:02 -0700)
committerIsaac Boukris <iboukris@sn-devel-184>
Tue, 4 Aug 2020 08:51:41 +0000 (08:51 +0000)
No logic change.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
source3/libsmb/namequery.c

index 5d4b1ee545f0e8cc27225995de0a12d23958c84d..2ad01f0eb995c3b786b4ebabb69ca56238a94d26 100644 (file)
@@ -2593,6 +2593,7 @@ NTSTATUS internal_resolve_name(const char *name,
        const char *tok;
        NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
        int i;
+       bool ok;
        TALLOC_CTX *frame = NULL;
 
        *return_iplist = NULL;
@@ -2680,9 +2681,10 @@ NTSTATUS internal_resolve_name(const char *name,
                        if (!NT_STATUS_IS_OK(status)) {
                                continue;
                        }
-                       if (!convert_ss2service(return_iplist,
+                       ok = convert_ss2service(return_iplist,
                                                ss_list,
-                                               return_count)) {
+                                               return_count);
+                       if (!ok) {
                                status = NT_STATUS_NO_MEMORY;
                                goto fail;
                        }