]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
afs: drop usage of folio_file_pos
authorKairui Song <kasong@tencent.com>
Tue, 21 May 2024 17:58:47 +0000 (01:58 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 4 Jul 2024 02:29:55 +0000 (19:29 -0700)
folio_file_pos is only needed for mixed usage of page cache and swap
cache, for pure page cache usage, the caller can just use folio_pos
instead.

It can't be a swap cache page here.  Swap mapping may only call into fs
through swap_rw and that is not supported for afs.  So just drop it and
use folio_pos instead.

Link: https://lkml.kernel.org/r/20240521175854.96038-6-ryncsn@gmail.com
Signed-off-by: Kairui Song <kasong@tencent.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Marc Dionne <marc.dionne@auristor.com>
Cc: Anna Schumaker <anna@kernel.org>
Cc: Barry Song <v-songbaohua@oppo.com>
Cc: Chao Yu <chao@kernel.org>
Cc: Chris Li <chrisl@kernel.org>
Cc: David Hildenbrand <david@redhat.com>
Cc: "Huang, Ying" <ying.huang@intel.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Ilya Dryomov <idryomov@gmail.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Jeff Layton <jlayton@kernel.org>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: NeilBrown <neilb@suse.de>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: Xiubo Li <xiubli@redhat.com>
Cc: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/afs/dir.c
fs/afs/dir_edit.c

index 67afe68972d5c7e62a5db77f41d5b81916eb432d..f8622ed72e08126aebfb9ede3943ba54469b2d78 100644 (file)
@@ -533,14 +533,14 @@ static int afs_dir_iterate(struct inode *dir, struct dir_context *ctx,
                        break;
                }
 
-               offset = round_down(ctx->pos, sizeof(*dblock)) - folio_file_pos(folio);
+               offset = round_down(ctx->pos, sizeof(*dblock)) - folio_pos(folio);
                size = min_t(loff_t, folio_size(folio),
-                            req->actual_len - folio_file_pos(folio));
+                            req->actual_len - folio_pos(folio));
 
                do {
                        dblock = kmap_local_folio(folio, offset);
                        ret = afs_dir_iterate_block(dvnode, ctx, dblock,
-                                                   folio_file_pos(folio) + offset);
+                                                   folio_pos(folio) + offset);
                        kunmap_local(dblock);
                        if (ret != 1)
                                goto out;
index e2fa577b66fe0ace93722e303aa54de7f8c47fc4..a71bff10496b2b9c5282086aec950fe85d79491a 100644 (file)
@@ -256,7 +256,7 @@ void afs_edit_dir_add(struct afs_vnode *vnode,
                        folio = folio0;
                }
 
-               block = kmap_local_folio(folio, b * AFS_DIR_BLOCK_SIZE - folio_file_pos(folio));
+               block = kmap_local_folio(folio, b * AFS_DIR_BLOCK_SIZE - folio_pos(folio));
 
                /* Abandon the edit if we got a callback break. */
                if (!test_bit(AFS_VNODE_DIR_VALID, &vnode->flags))
@@ -417,7 +417,7 @@ void afs_edit_dir_remove(struct afs_vnode *vnode,
                        folio = folio0;
                }
 
-               block = kmap_local_folio(folio, b * AFS_DIR_BLOCK_SIZE - folio_file_pos(folio));
+               block = kmap_local_folio(folio, b * AFS_DIR_BLOCK_SIZE - folio_pos(folio));
 
                /* Abandon the edit if we got a callback break. */
                if (!test_bit(AFS_VNODE_DIR_VALID, &vnode->flags))