]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
crypto: rockchip - drop redundant crypto_skcipher_ivsize() calls
authorKarina Yankevich <k.yankevich@omp.ru>
Wed, 5 Nov 2025 14:52:04 +0000 (17:52 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 14 Nov 2025 10:15:48 +0000 (18:15 +0800)
The function already initialized the ivsize variable
at the point of declaration, let's use it instead of
calling crypto_skcipher_ivsize() extra couple times.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 57d67c6e8219 ("crypto: rockchip - rework by using crypto_engine")
Signed-off-by: Karina Yankevich <k.yankevich@omp.ru>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/rockchip/rk3288_crypto_skcipher.c

index 9393e10671c2481e7c77f37774ce5fe278231ade..e80f9148c0129f4b1d14fb105cbf06b91019876b 100644 (file)
@@ -321,8 +321,7 @@ static int rk_cipher_run(struct crypto_engine *engine, void *async_req)
        algt->stat_req++;
        rkc->nreq++;
 
-       ivsize = crypto_skcipher_ivsize(tfm);
-       if (areq->iv && crypto_skcipher_ivsize(tfm) > 0) {
+       if (areq->iv && ivsize > 0) {
                if (rctx->mode & RK_CRYPTO_DEC) {
                        offset = areq->cryptlen - ivsize;
                        scatterwalk_map_and_copy(rctx->backup_iv, areq->src,