dict: Unref dict connection immediately when connection is destroyed

The delayed unrefing is needed when calling from dict command callbacks to
avoid calling dict_deinit() too early. But the connection's destroy() vfunc
can't be called directly from dict command callbacks, so there's no need
to add further delays. Especially when this happens at deinit where there is
no possibility of calling the delayed callback anymore.

diff --git a/src/dict/dict-connection.c b/src/dict/dict-connection.c
index b23272532e55afb078511e2a450952fc183478f3..6a87c27146ef13117139fdc02877407f2643d7fa 100644 (file)
--- a/src/dict/dict-connection.c
+++ b/src/dict/dict-connection.c
@@ -240,7 +240,7 @@ static void dict_connection_destroy(struct connection *_conn)
        dict_connection_cmds_output_more(conn);
 
        io_remove(&conn->conn.io);
-       dict_connection_unref_safe(conn);
+       dict_connection_unref(conn);
 }
 
 unsigned int dict_connections_current_count(void)