]> git.ipfire.org Git - thirdparty/git.git/commitdiff
blame: drop explicit check for commit graph
authorPatrick Steinhardt <ps@pks.im>
Thu, 4 Sep 2025 12:49:55 +0000 (14:49 +0200)
committerJunio C Hamano <gitster@pobox.com>
Thu, 4 Sep 2025 23:16:21 +0000 (16:16 -0700)
Our blaming subsystem knows to use bloom filters from commit graphs to
speed up the whole computation. The setup of this happens in
`setup_blame_bloom_data()`, where we first verify that we even have a
commit graph in the first place. This check is redundant though, as we
call `get_bloom_filter_settings()` immediately afterwards which, which
already knows to return a `NULL` pointer in case we don't have a commit
graph.

Drop the redundant check.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
blame.c

diff --git a/blame.c b/blame.c
index f1c0670144b67cb61b84230782e8292c7ae15b22..cb0b08342308ef7599791abbcf4148e442a7c68e 100644 (file)
--- a/blame.c
+++ b/blame.c
@@ -2909,9 +2909,6 @@ void setup_blame_bloom_data(struct blame_scoreboard *sb)
        struct blame_bloom_data *bd;
        struct bloom_filter_settings *bs;
 
-       if (!sb->repo->objects->commit_graph)
-               return;
-
        bs = get_bloom_filter_settings(sb->repo);
        if (!bs)
                return;