]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: xilinx-nwl: Silence 'set affinity failed' warning
authorMarek Vasut <marek.vasut+renesas@mailbox.org>
Tue, 23 Jul 2024 13:27:13 +0000 (15:27 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 6 Aug 2024 17:52:17 +0000 (12:52 -0500)
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows
migrate_one_irq() to exit right away, without warnings like this:

  IRQ...: set affinity failed(-22)

Remove the .irq_set_affinity() implementation that is no longer needed.

Link: https://lore.kernel.org/r/20240723132958.41320-14-marek.vasut+renesas@mailbox.org
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
[bhelgaas: commit log]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
drivers/pci/controller/pcie-xilinx-nwl.c

index 0408f4d612b5af4702e3fd6c67b2dce3f81bf148..d5615cf8563f4d50fbcc380273f12eb7f3c58058 100644 (file)
@@ -425,8 +425,8 @@ static struct irq_chip nwl_msi_irq_chip = {
 };
 
 static struct msi_domain_info nwl_msi_domain_info = {
-       .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
-                 MSI_FLAG_MULTI_PCI_MSI),
+       .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
+                MSI_FLAG_NO_AFFINITY | MSI_FLAG_MULTI_PCI_MSI,
        .chip = &nwl_msi_irq_chip,
 };
 #endif
@@ -441,16 +441,9 @@ static void nwl_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
        msg->data = data->hwirq;
 }
 
-static int nwl_msi_set_affinity(struct irq_data *irq_data,
-                               const struct cpumask *mask, bool force)
-{
-       return -EINVAL;
-}
-
 static struct irq_chip nwl_irq_chip = {
        .name = "Xilinx MSI",
        .irq_compose_msi_msg = nwl_compose_msi_msg,
-       .irq_set_affinity = nwl_msi_set_affinity,
 };
 
 static int nwl_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,