]> git.ipfire.org Git - thirdparty/rrdtool-1.x.git/commitdiff
src/rrd_daemon.c: fix Coverity CID#26525 Buffer not null terminated
authorMarek Schimara <Marek.Schimara@bull.net>
Thu, 16 Jun 2016 11:45:54 +0000 (13:45 +0200)
committerMarek Schimara <Marek.Schimara@bull.net>
Thu, 23 Jun 2016 14:32:33 +0000 (16:32 +0200)
        CWE-170 / https://cwe.mitre.org/data/definitions/170.html

src/rrd_daemon.c

index 6e8e687ea87ee6873cd562a6d2b195ebcdaa3a13..65b7c2c091ade7cec54e78acd77a2c7634b455a4 100644 (file)
@@ -1500,8 +1500,10 @@ static int handle_request_update (HANDLER_PROTO) /* {{{ */
   cache_item_t *ci;
 
   /* save it for the journal later */
-  if (!JOURNAL_REPLAY(sock))
+  if (!JOURNAL_REPLAY(sock)) {
     strncpy(orig_buf, buffer, min(RRD_CMD_MAX,buffer_size));
+    orig_buf[min(RRD_CMD_MAX,buffer_size) - 1] = '\0';
+  }
 
   status = buffer_get_field (&buffer, &buffer_size, &pbuffile);
   if (status != 0) {