media: staging/ipu7: Use %pe format specifier

The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR().

This patch fixes this cocci report:
./ipu7/ipu7-isys-csi-phy.c:311:23-30: WARNING: Consider using %pe to print PTR_ERR()
./ipu7/ipu7-isys-csi2.c:59:22-29: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c b/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c
index b8c5db7ae3009e16264d7aaca6d4d237c1402ab7..2d57178835188a44b002b38712437cbd551751a5 100644 (file)
--- a/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c
+++ b/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c
@@ -307,8 +307,8 @@ static int ipu7_isys_csi_ctrl_dids_config(struct ipu7_isys_csi2 *csi2, u32 id)
 
        pad = media_entity_remote_source_pad_unique(&csi2->asd.sd.entity);
        if (IS_ERR(pad)) {
-               dev_warn(dev, "can't get remote source pad of %s (%ld)\n",
-                        csi2->asd.sd.name, PTR_ERR(pad));
+               dev_warn(dev, "can't get remote source pad of %s (%pe)\n",
+                        csi2->asd.sd.name, pad);
                return PTR_ERR(pad);
        }
 

diff --git a/drivers/staging/media/ipu7/ipu7-isys-csi2.c b/drivers/staging/media/ipu7/ipu7-isys-csi2.c
index 4023db4a6466dd57f0ac007847bdd74bcdf394f7..f34eabfe8a985f29fa48b4a8896a058fde2f2b2f 100644 (file)
--- a/drivers/staging/media/ipu7/ipu7-isys-csi2.c
+++ b/drivers/staging/media/ipu7/ipu7-isys-csi2.c
@@ -55,8 +55,8 @@ s64 ipu7_isys_csi2_get_link_freq(struct ipu7_isys_csi2 *csi2)
        src_pad = media_entity_remote_source_pad_unique(&csi2->asd.sd.entity);
        if (IS_ERR(src_pad)) {
                dev_err(&csi2->isys->adev->auxdev.dev,
-                       "can't get source pad of %s (%ld)\n",
-                       csi2->asd.sd.name, PTR_ERR(src_pad));
+                       "can't get source pad of %s (%pe)\n",
+                       csi2->asd.sd.name, src_pad);
                return PTR_ERR(src_pad);
        }