Other architectures also had bugs, or did unnecessary work.
+2015-08-15 Paul Pluzhnikov <ppluzhnikov@google.com>
+
+ [BZ #18084]
+ * debug/tst-backtrace2.c (do_test): Add test for BZ #18084.
+ * sysdeps/arm/backtrace.c (__backtrace): Handle size <= 0.
+ * sysdeps/i386/backtrace.c (__backtrace): Likewise.
+ * sysdeps/m68k/backtrace.c (__backtrace): Likewise.
+ * sysdeps/microblaze/backtrace.c (__backtrace): Likewise.
+ * sysdeps/s390/s390-32/backtrace.c (__backtrace): Likewise.
+ * sysdeps/s390/s390-64/backtrace.c (__backtrace): Likewise.
+ * sysdeps/sparc/backtrace.c (__backtrace): Likewise.
+ * sysdeps/x86_64/backtrace.c (__backtrace): Likewise.
+
2015-08-15 Zack Weinberg <zackw@panix.com>
[BZ #18795]
* The following bugs are resolved with this release:
- 16517, 16519, 16520, 16734, 17905, 18086, 18265, 18480, 18525, 18618,
- 18647, 18661, 18674, 18778, 18781, 18787, 18789, 18790, 18795, 18820,
- 18824.
+ 16517, 16519, 16520, 16734, 17905, 18084, 18086, 18265, 18480, 18525,
+ 18618, 18647, 18661, 18674, 18778, 18781, 18787, 18789, 18790, 18795,
+ 18820, 18824.
+
\f
Version 2.22
NO_INLINE static int
do_test (void)
{
+ /* Test BZ #18084. */
+ void *buffer[1];
+
+ if (backtrace (buffer, 0) != 0)
+ FAIL ();
+
fn3 ();
return ret;
}
int size;
{
struct trace_arg arg = { .array = array, .size = size, .cnt = -1 };
+
+ if (size <= 0)
+ return 0;
+
#ifdef SHARED
__libc_once_define (static, once);
return 0;
#endif
- if (size >= 1)
- unwind_backtrace (backtrace_helper, &arg);
+ unwind_backtrace (backtrace_helper, &arg);
if (arg.cnt > 1 && arg.array[arg.cnt - 1] == NULL)
--arg.cnt;
int size;
{
struct trace_arg arg = { .array = array, .size = size, .cnt = -1 };
+
+ if (size <= 0)
+ return 0;
+
#ifdef SHARED
__libc_once_define (static, once);
return 0;
#endif
- if (size >= 1)
- unwind_backtrace (backtrace_helper, &arg);
+ unwind_backtrace (backtrace_helper, &arg);
if (arg.cnt > 1 && arg.array[arg.cnt - 1] == NULL)
--arg.cnt;
__backtrace (void **array, int size)
{
struct trace_arg arg = { .array = array, .size = size, .cnt = -1 };
+
+ if (size <= 0)
+ return 0;
+
#ifdef SHARED
__libc_once_define (static, once);
return 0;
#endif
- if (size >= 1)
- unwind_backtrace (backtrace_helper, &arg);
+ unwind_backtrace (backtrace_helper, &arg);
if (arg.cnt > 1 && arg.array[arg.cnt - 1] == NULL)
--arg.cnt;
int count;
int rc = 0;
+ if (size <= 0)
+ return 0;
+
__asm__ __volatile__ ("mfs %0, rpc"
: "=r"(pc));
__backtrace (void **array, int size)
{
struct trace_arg arg = { .array = array, .size = size, .cnt = -1 };
+
+ if (size <= 0)
+ return 0;
+
#ifdef SHARED
__libc_once_define (static, once);
return __backchain_backtrace (array, size);
#endif
- if (size >= 1)
- unwind_backtrace (backtrace_helper, &arg);
+ unwind_backtrace (backtrace_helper, &arg);
return arg.cnt != -1 ? arg.cnt : 0;
}
__backtrace (void **array, int size)
{
struct trace_arg arg = { .array = array, .size = size, .cnt = -1 };
+
+ if (size <= 0)
+ return 0;
+
#ifdef SHARED
__libc_once_define (static, once);
return __backchain_backtrace (array, size);
#endif
- if (size >= 1)
- unwind_backtrace (backtrace_helper, &arg);
+ unwind_backtrace (backtrace_helper, &arg);
return arg.cnt != -1 ? arg.cnt : 0;
}
bool use_unwinder;
int count;
- if (!size)
+ if (size <= 0)
return 0;
use_unwinder = true;
int size;
{
struct trace_arg arg = { .array = array, .cfa = 0, .size = size, .cnt = -1 };
+
+ if (size <= 0)
+ return 0;
+
#ifdef SHARED
__libc_once_define (static, once);
return 0;
#endif
- if (size >= 1)
- unwind_backtrace (backtrace_helper, &arg);
+ unwind_backtrace (backtrace_helper, &arg);
/* _Unwind_Backtrace seems to put NULL address above
_start. Fix it up here. */