]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
um: remove PATH_MAX use
authorJohannes Berg <johannes.berg@intel.com>
Thu, 24 Oct 2024 07:52:51 +0000 (09:52 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Thu, 24 Oct 2024 07:52:51 +0000 (09:52 +0200)
Evidently, PATH_MAX isn't always defined, at least not via <limits.h>.
Simply remove the use and replace it by a constant 4k. As stat::st_size
is zero for /proc/self/exe we can't even size it automatically, and it
seems unlikely someone's going to try to run UML with such a path.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202410240553.gYNIXN8i-lkp@intel.com/
Fixes: 031acdcfb566 ("um: restore process name")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
arch/um/os-Linux/main.c

index 5e0cba5aee931350d5b9f3bf65c7fbcb0ec1cec7..0afcdeb8995b755a59f6ee1c0010f6414cd1aa85 100644 (file)
@@ -10,7 +10,6 @@
 #include <errno.h>
 #include <signal.h>
 #include <string.h>
-#include <limits.h>
 #include <sys/resource.h>
 #include <sys/personality.h>
 #include <as-layout.h>
@@ -114,7 +113,7 @@ int __init main(int argc, char **argv, char **envp)
        ret = personality(PER_LINUX | ADDR_NO_RANDOMIZE);
        if (ret >= 0 && (ret & (PER_LINUX | ADDR_NO_RANDOMIZE)) !=
                         (PER_LINUX | ADDR_NO_RANDOMIZE)) {
-               char buf[PATH_MAX] = {};
+               char buf[4096] = {};
                ssize_t ret;
 
                ret = readlink("/proc/self/exe", buf, sizeof(buf));